Skip to content

Conversation

@pvzig
Copy link
Collaborator

@pvzig pvzig commented Mar 27, 2019

No description provided.

@Vkt0r
Copy link
Member

Vkt0r commented Mar 27, 2019

@pvzig Thanks for creating this PR. I was planning to make a PR with this tomorrow 😅. It was happening a weird crash with the tvOS tests. I re-run it again and now it's green!

@Vkt0r
Copy link
Member

Vkt0r commented Mar 27, 2019

@pvzig There is only one small piece of code we're missing to update and I think we have missed it for a while.

public static let VERSION = "1.3.3"

We need to update this variable from the resources, but we can create a PR for that at some point later.

@Vkt0r Vkt0r self-requested a review March 27, 2019 02:15
@pvzig
Copy link
Collaborator Author

pvzig commented Mar 27, 2019

Did the lazy thing for now and bumped it manually 🙃

Copy link
Member

@Vkt0r Vkt0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Vkt0r Vkt0r merged commit 57faa5d into stable Mar 27, 2019
@pvzig pvzig deleted the 1.4.6 branch March 27, 2019 02:59
@pvzig
Copy link
Collaborator Author

pvzig commented Mar 27, 2019

Tagged a release and pushed it to CocoaPods Trunk.

@Vkt0r
Copy link
Member

Vkt0r commented Mar 27, 2019

Cool @pvzig thanks!

tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
Bump version to 1.4.6 for Swift 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants