-
Notifications
You must be signed in to change notification settings - Fork 554
Disambiguate swift method call #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After more research, not only does this issue only occur in the latest Beta Xcode 10.2 (10P82s), but the fix actually breaks non-beta Xcode 10.1 (10B61)! Not sure what to do here, but it should not be merged just yet... |
|
It would be helpful if you could open an issue for this so that anyone searching for it can more easily find it. I spent quite a bit of time coming to the same fix and only stumbled upon your branch by accident. |
I've been working on updating this library to 4.2 + Xcode 10.2, and 5.0 + Xcode 10.2. The answer is to conditionally compile the new code: This works because the new version of Swift 4.2 in Xcode 10.2 is 4.2.2. |
|
@alanzeino That's a good catch 👍.
I can assume we can expect a draft PR soon then with the update 😅 ? |
|
Hello, I actually opened an issue for this because I didn't find this PR (thanks @Vkt0r for referencing). In order to fix this you can simply remove the |
I'm close, just got one issue to solve and I can PR it. |
|
In Xcode 10.2b4 this change isn't needed anymore. |
|
Closing this in favor of #370. |

No description provided.