Skip to content

Commit ec4469e

Browse files
committed
Use standard divider for separator in gist_header
This mirrors the separator used in list items
1 parent b8f4708 commit ec4469e

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

app/res/layout/gist_header.xml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,26 @@
1818
android:layout_width="match_parent"
1919
android:layout_height="match_parent"
2020
android:orientation="vertical"
21-
android:paddingLeft="5dp"
22-
android:paddingRight="5dp"
2321
android:paddingTop="5dp" >
2422

2523
<TextView
2624
android:id="@+id/tv_gist_creation"
2725
style="@style/ListSubtitleText"
2826
android:layout_width="match_parent"
2927
android:gravity="center_vertical"
30-
android:paddingLeft="5dp"
31-
android:paddingRight="5dp"
28+
android:paddingLeft="10dp"
29+
android:paddingRight="10dp"
3230
android:singleLine="true" />
3331

3432
<TextView
3533
android:id="@+id/tv_gist_description"
3634
style="@style/ListTitleText"
3735
android:layout_width="match_parent"
3836
android:autoLink="web"
39-
android:padding="5dp"
37+
android:paddingBottom="5dp"
38+
android:paddingLeft="10dp"
39+
android:paddingRight="10dp"
40+
android:paddingTop="5dp"
4041
android:textColorLink="@color/text_link" />
4142

4243
<TextView
@@ -45,8 +46,8 @@
4546
android:layout_width="match_parent"
4647
android:gravity="center_vertical"
4748
android:paddingBottom="5dp"
48-
android:paddingLeft="5dp"
49-
android:paddingRight="5dp"
49+
android:paddingLeft="10dp"
50+
android:paddingRight="10dp"
5051
android:singleLine="true" />
5152

5253
<View style="@style/Separator" />

app/res/values/colors.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
<color name="list_divider_bottom">#FFFFFF</color>
4848
<color name="text_link">#4183C4</color>
4949
<color name="text_news_details">#666666</color>
50-
<color name="separator">#E5E5E5</color>
5150
<color name="label_outer">#55000000</color>
5251
<color name="label_inner">#55FFFFFF</color>
5352
<color name="milestone_border">#ABABAB</color>

app/res/values/styles.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@
107107

108108
<style name="Separator">
109109
<item name="android:layout_width">match_parent</item>
110-
<item name="android:layout_height">1dp</item>
111-
<item name="android:background">@color/separator</item>
110+
<item name="android:layout_height">2dp</item>
111+
<item name="android:background">@drawable/list_divider</item>
112112
</style>
113113

114114
<style name="TitleText">

0 commit comments

Comments
 (0)