Add unit tests of IssueFilter

kevinsawicki · kevinsawicki · commit b5593c19011a · 2012-05-18T22:49:22.000-07:00
diff --git a/app/src/main/java/com/github/mobile/core/issue/IssueFilter.java b/app/src/main/java/com/github/mobile/core/issue/IssueFilter.java
@@ -240,8 +240,9 @@ public CharSequence toDisplay() {
 
     @Override
     public int hashCode() {
-        return Arrays.hashCode(new Object[] { open, assignee, milestone, assignee,
-                repository != null ? repository.generateId() : null, labels });
+        return Arrays.hashCode(new Object[] { open, assignee != null ? assignee.getId() : null,
+                milestone != null ? milestone.getNumber() : null, assignee != null ? assignee.getId() : null,
+                repository != null ? repository.getId() : null, labels });
     }
 
     private boolean isEqual(Object a, Object b) {
@@ -262,6 +263,10 @@ private boolean isEqual(User a, User b) {
         return a != null && b != null && a.getId() == b.getId();
     }
 
+    private boolean isEqual(Repository a, Repository b) {
+        return a != null && b != null && a.getId() == b.getId();
+    }
+
     @Override
     public boolean equals(Object o) {
         if (o == this)
diff --git a/app/src/test/java/com/github/mobile/core/issue/IssueFilterTest.java b/app/src/test/java/com/github/mobile/core/issue/IssueFilterTest.java
@@ -0,0 +1,68 @@
+/*
+ * Copyright 2012 GitHub Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.github.mobile.core.issue;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import org.eclipse.egit.github.core.Milestone;
+import org.eclipse.egit.github.core.Repository;
+import org.eclipse.egit.github.core.User;
+import org.junit.Test;
+
+/**
+ * Unit tests of {@link IssueFilter}
+ */
+public class IssueFilterTest {
+
+    /**
+     * Verify {@link IssueFilter#equals(Object)}
+     */
+    @Test
+    public void equalFilter() {
+        Repository repo = new Repository().setId(1);
+        IssueFilter filter1 = new IssueFilter(repo);
+
+        assertFalse(filter1.equals(null));
+        assertFalse(filter1.equals(""));
+        assertTrue(filter1.equals(filter1));
+
+        IssueFilter filter2 = new IssueFilter(repo);
+        assertEquals(filter1, filter2);
+        assertEquals(filter1.hashCode(), filter2.hashCode());
+
+        User user = new User().setId(2);
+        filter1.setAssignee(user);
+        assertFalse(filter1.equals(filter2));
+        filter2.setAssignee(user);
+        assertEquals(filter1, filter2);
+        assertEquals(filter1.hashCode(), filter2.hashCode());
+
+        filter1.setOpen(false);
+        assertFalse(filter1.equals(filter2));
+        filter2.setOpen(false);
+        assertEquals(filter1, filter2);
+        assertEquals(filter1.hashCode(), filter2.hashCode());
+
+        Milestone milestone = new Milestone().setNumber(3);
+        filter1.setMilestone(milestone);
+        assertFalse(filter1.equals(filter2));
+        filter2.setMilestone(milestone);
+        assertEquals(filter1, filter2);
+        assertEquals(filter1.hashCode(), filter2.hashCode());
+    }
+}
