Only enable save menu when title is non-empty

kevinsawicki · kevinsawicki · commit a899c07fba5c · 2012-06-14T11:14:22.000-07:00
diff --git a/app/res/menu/issue_edit.xml b/app/res/menu/issue_edit.xml
@@ -17,7 +17,8 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android" >
 
     <item
-        android:id="@+id/m_edit"
+        android:id="@+id/m_apply"
+        android:enabled="false"
         android:icon="@drawable/action_save"
         android:showAsAction="ifRoom"
         android:title="@string/save"/>
diff --git a/app/src/main/java/com/github/mobile/ui/issue/EditIssueActivity.java b/app/src/main/java/com/github/mobile/ui/issue/EditIssueActivity.java
@@ -28,6 +28,8 @@
 import static com.github.mobile.RequestCodes.ISSUE_MILESTONE_UPDATE;
 import android.content.Intent;
 import android.os.Bundle;
+import android.text.Editable;
+import android.text.TextUtils;
 import android.view.View;
 import android.view.View.OnClickListener;
 import android.widget.EditText;
@@ -45,6 +47,7 @@
 import com.github.mobile.R.string;
 import com.github.mobile.ui.DialogFragmentActivity;
 import com.github.mobile.ui.StyledText;
+import com.github.mobile.ui.TextWatcherAdapter;
 import com.github.mobile.util.AvatarLoader;
 import com.google.inject.Inject;
 
@@ -149,6 +152,8 @@ public static Intent createIntent(final Issue issue,
 
     private RepositoryId repository;
 
+    private MenuItem saveItem;
+
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -202,6 +207,15 @@ public void onClick(View v) {
             }
         });
 
+        titleText.addTextChangedListener(new TextWatcherAdapter() {
+
+            @Override
+            public void afterTextChanged(Editable s) {
+                updateSaveMenu(s);
+            }
+        });
+
+        updateSaveMenu();
         updateView();
     }
 
@@ -277,16 +291,28 @@ protected void onSaveInstanceState(Bundle outState) {
         outState.putSerializable(EXTRA_ISSUE, issue);
     }
 
+    private void updateSaveMenu() {
+        if (titleText != null)
+            updateSaveMenu(titleText.getText());
+    }
+
+    private void updateSaveMenu(final CharSequence text) {
+        if (saveItem != null)
+            saveItem.setEnabled(!TextUtils.isEmpty(text));
+    }
+
     @Override
     public boolean onCreateOptionsMenu(Menu options) {
         getSupportMenuInflater().inflate(menu.issue_edit, options);
+        saveItem = options.findItem(id.m_apply);
+        updateSaveMenu();
         return true;
     }
 
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         switch (item.getItemId()) {
-        case id.m_edit:
+        case id.m_apply:
             issue.setTitle(titleText.getText().toString());
             issue.setBody(bodyText.getText().toString());
             if (issue.getNumber() > 0)
diff --git a/integration-tests/src/main/java/com/github/mobile/EditIssueActivityTest.java b/integration-tests/src/main/java/com/github/mobile/EditIssueActivityTest.java
@@ -15,7 +15,12 @@
  */
 package com.github.mobile;
 
+import static android.view.KeyEvent.KEYCODE_DEL;
+import android.view.View;
+import android.widget.EditText;
+
 import com.github.mobile.ui.issue.EditIssueActivity;
+import com.viewpagerindicator.R.id;
 
 import org.eclipse.egit.github.core.Repository;
 import org.eclipse.egit.github.core.User;
@@ -41,4 +46,21 @@ protected void setUp() throws Exception {
         repo.setOwner(new User().setLogin("owner"));
         setActivityIntent(EditIssueActivity.createIntent(repo, "an issue"));
     }
+
+    /**
+     * Verify save menu is properly enabled/disable depending on the issue have
+     * a non-empty title
+     * 
+     * @throws Throwable
+     */
+    public void testSaveMenuEnabled() throws Throwable {
+        View saveMenu = view(id.m_apply);
+        assertFalse(saveMenu.isEnabled());
+        EditText title = editText(id.et_issue_title);
+        focus(title);
+        send("a");
+        assertTrue(saveMenu.isEnabled());
+        sendKeys(KEYCODE_DEL);
+        assertFalse(saveMenu.isEnabled());
+    }
 }
