Skip to content

Commit a01cc01

Browse files
Bananeweizenkevinsawicki
authored andcommitted
Extract icon strings into separate resource
This prevents these icons from ending up in localized strings.xml files.
1 parent 438e082 commit a01cc01

2 files changed

Lines changed: 25 additions & 5 deletions

File tree

app/res/values/strings.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,9 +158,6 @@
158158
<string name="anonymous">Anonymous</string>
159159
<string name="message_filter_saved">Issue filter saved to bookmarks</string>
160160
<string name="recent">Recent</string>
161-
<string name="icon_pull_request">\uf20E</string>
162-
<string name="icon_comment">\uf04f</string>
163-
<string name="icon_file">\uf211</string>
164161
<string name="section_issue_status">Status:</string>
165162
<string name="status_open">Open</string>
166163
<string name="status_closed">Closed</string>
@@ -183,8 +180,6 @@
183180
<string name="members">Members</string>
184181
<string name="closing_issue">Closing Issue…</string>
185182
<string name="reopening_issue">Reopening Issue…</string>
186-
<string name="icon_watch">\uf04E</string>
187-
<string name="icon_fork">\uf020</string>
188183
<string name="avatar">Avatar</string>
189184
<string name="creating_issue">Creating Issue…</string>
190185
<string name="prefix_created">created\u0020</string>

app/res/values/typeface.xml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
3+
Copyright 2012 GitHub Inc.
4+
5+
Licensed under the Apache License, Version 2.0 (the "License");
6+
you may not use this file except in compliance with the License.
7+
You may obtain a copy of the License at
8+
9+
http://www.apache.org/licenses/LICENSE-2.0
10+
11+
Unless required by applicable law or agreed to in writing, software
12+
distributed under the License is distributed on an "AS IS" BASIS,
13+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
See the License for the specific language governing permissions and
15+
limitations under the License.
16+
-->
17+
<resources>
18+
19+
<string name="icon_pull_request">\uf20E</string>
20+
<string name="icon_comment">\uf04f</string>
21+
<string name="icon_file">\uf211</string>
22+
<string name="icon_watch">\uf04E</string>
23+
<string name="icon_fork">\uf020</string>
24+
25+
</resources>

0 commit comments

Comments
 (0)