Ensure pager and tab host don't get created twice

kevinsawicki · kevinsawicki · commit 686cdda3828c · 2012-08-30T17:46:50.000-07:00
Also hide tab host when activity is in a full loading
state
diff --git a/app/src/main/java/com/github/mobile/ui/TabPagerActivity.java b/app/src/main/java/com/github/mobile/ui/TabPagerActivity.java
@@ -104,6 +104,9 @@ private void updateCurrentItem(final int newPosition) {
     }
 
     private void createPager() {
+        if (pager != null)
+            return;
+
         pager = (ViewPager) findViewById(id.vp_pages);
         pager.setOnPageChangeListener(new OnPageChangeListener() {
 
@@ -125,6 +128,9 @@ public void onPageScrollStateChanged(int state) {
     }
 
     private void createTabs() {
+        if (host != null)
+            return;
+
         host = (TabHost) findViewById(id.th_tabs);
         host.setup();
         host.setOnTabChangedListener(new OnTabChangeListener() {
diff --git a/app/src/main/java/com/github/mobile/ui/repo/RepositoryViewActivity.java b/app/src/main/java/com/github/mobile/ui/repo/RepositoryViewActivity.java
@@ -87,6 +87,7 @@ protected void onCreate(Bundle savedInstanceState) {
             createTabPager();
             avatars.bind(getSupportActionBar(), owner);
             ViewUtils.setGone(loadingBar, false);
+            ViewUtils.setGone(host, true);
             ViewUtils.setGone(pager, true);
             new RefreshRepositoryTask(this, repository) {
 
@@ -133,6 +134,7 @@ private void configurePager() {
         avatars.bind(getSupportActionBar(), repository.getOwner());
         createTabPager();
         ViewUtils.setGone(loadingBar, true);
+        ViewUtils.setGone(host, false);
         ViewUtils.setGone(pager, false);
     }
 
diff --git a/app/src/main/java/com/github/mobile/ui/user/UserViewActivity.java b/app/src/main/java/com/github/mobile/ui/user/UserViewActivity.java
@@ -72,6 +72,7 @@ protected void onCreate(Bundle savedInstanceState) {
         else {
             createTabPager();
             ViewUtils.setGone(loadingBar, false);
+            ViewUtils.setGone(host, true);
             ViewUtils.setGone(pager, true);
             new RefreshUserTask(this, user.getLogin()) {
 
@@ -99,6 +100,7 @@ private void configurePager() {
         avatars.bind(getSupportActionBar(), user);
         createTabPager();
         ViewUtils.setGone(loadingBar, true);
+        ViewUtils.setGone(host, false);
         ViewUtils.setGone(pager, false);
     }
 
