Extend PagerActivity in IssuesViewActivity

kevinsawicki · kevinsawicki · commit 35e196bef306 · 2012-09-06T09:15:24.000-07:00
diff --git a/app/src/main/java/com/github/mobile/ui/issue/IssuesViewActivity.java b/app/src/main/java/com/github/mobile/ui/issue/IssuesViewActivity.java
@@ -21,7 +21,6 @@
 import static com.github.mobile.Intents.EXTRA_REPOSITORY;
 import android.content.Intent;
 import android.os.Bundle;
-import android.support.v4.view.ViewPager.OnPageChangeListener;
 
 import com.actionbarsherlock.app.ActionBar;
 import com.github.mobile.Intents.Builder;
@@ -31,7 +30,8 @@
 import com.github.mobile.core.issue.IssueStore;
 import com.github.mobile.core.issue.IssueUtils;
 import com.github.mobile.core.repo.RefreshRepositoryTask;
-import com.github.mobile.ui.DialogFragmentActivity;
+import com.github.mobile.ui.FragmentProvider;
+import com.github.mobile.ui.PagerActivity;
 import com.github.mobile.ui.UrlLauncher;
 import com.github.mobile.ui.ViewPager;
 import com.github.mobile.util.AvatarLoader;
@@ -54,8 +54,7 @@
 /**
  * Activity to display a collection of issues or pull requests in a pager
  */
-public class IssuesViewActivity extends DialogFragmentActivity implements
-        OnPageChangeListener {
+public class IssuesViewActivity extends PagerActivity {
 
     private static final String EXTRA_PULL_REQUESTS = "pullRequests";
 
@@ -219,11 +218,6 @@ protected void onSuccess(Repository fullRepository)
             }.execute();
     }
 
-    public void onPageScrolled(int position, float positionOffset,
-            int positionOffsetPixels) {
-        // Intentionally left blank
-    }
-
     private void updateTitle(final int position) {
         int number = issueNumbers[position];
         boolean pullRequest = pullRequests[position];
@@ -236,7 +230,10 @@ private void updateTitle(final int position) {
                     getString(string.issue_title) + number);
     }
 
+    @Override
     public void onPageSelected(final int position) {
+        super.onPageSelected(position);
+
         if (repo != null) {
             updateTitle(position);
             return;
@@ -267,10 +264,6 @@ public void onPageSelected(final int position) {
         }
     }
 
-    public void onPageScrollStateChanged(int state) {
-        // Intentionally left blank
-    }
-
     @Override
     public void onDialogResult(int requestCode, int resultCode, Bundle arguments) {
         adapter.onDialogResult(pager.getCurrentItem(), requestCode, resultCode,
@@ -285,4 +278,8 @@ public void startActivity(Intent intent) {
         else
             super.startActivity(intent);
     }
+
+    protected FragmentProvider getProvider() {
+        return adapter;
+    }
 }
