Reuse assignee, milestone, and labels dialogs

kevinsawicki · kevinsawicki · commit 348bf2c8bfc9 · 2012-07-03T09:36:02.000-07:00
This allows the dialogs to immediately display when
opened again after the first successful load.

Previously the elements would be loaded each time
the dialog was opened.
diff --git a/app/src/main/java/com/github/mobile/ui/issue/EditIssueActivity.java b/app/src/main/java/com/github/mobile/ui/issue/EditIssueActivity.java
@@ -143,6 +143,12 @@ public static Intent createIntent(final Issue issue,
 
     private MenuItem saveItem;
 
+    private MilestoneDialog milestoneDialog;
+
+    private AssigneeDialog assigneeDialog;
+
+    private LabelsDialog labelsDialog;
+
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
@@ -175,28 +181,34 @@ protected void onCreate(Bundle savedInstanceState) {
 
             @Override
             public void onClick(View v) {
-                new MilestoneDialog(EditIssueActivity.this,
-                        ISSUE_MILESTONE_UPDATE, repository, milestoneService)
-                        .show(issue.getMilestone());
+                if (milestoneDialog == null)
+                    milestoneDialog = new MilestoneDialog(
+                            EditIssueActivity.this, ISSUE_MILESTONE_UPDATE,
+                            repository, milestoneService);
+                milestoneDialog.show(issue.getMilestone());
             }
         });
 
         findViewById(id.ll_assignee).setOnClickListener(new OnClickListener() {
 
             @Override
             public void onClick(View v) {
-                new AssigneeDialog(EditIssueActivity.this,
-                        ISSUE_ASSIGNEE_UPDATE, repository, collaboratorService)
-                        .show(issue.getAssignee());
+                if (assigneeDialog == null)
+                    assigneeDialog = new AssigneeDialog(EditIssueActivity.this,
+                            ISSUE_ASSIGNEE_UPDATE, repository,
+                            collaboratorService);
+                assigneeDialog.show(issue.getAssignee());
             }
         });
 
         findViewById(id.ll_labels).setOnClickListener(new OnClickListener() {
 
             @Override
             public void onClick(View v) {
-                new LabelsDialog(EditIssueActivity.this, ISSUE_LABELS_UPDATE,
-                        repository, labelService).show(issue.getLabels());
+                if (labelsDialog == null)
+                    labelsDialog = new LabelsDialog(EditIssueActivity.this,
+                            ISSUE_LABELS_UPDATE, repository, labelService);
+                labelsDialog.show(issue.getLabels());
             }
         });
 
