Find index of ListView by calling indexOfChild() instead of iterating

SeanPONeil · SeanPONeil · commit 20f80799facc · 2012-10-15T17:24:09.000-07:00
through the views
diff --git a/extras/PullToRefreshListFragment/src/com/handmark/pulltorefresh/extras/listfragment/PullToRefreshListFragment.java b/extras/PullToRefreshListFragment/src/com/handmark/pulltorefresh/extras/listfragment/PullToRefreshListFragment.java
@@ -2,6 +2,7 @@
 
 import android.os.Bundle;
 import android.support.v4.app.ListFragment;
+import android.util.Log;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
@@ -34,21 +35,11 @@ public final View onCreateView(LayoutInflater inflater, ViewGroup container, Bun
 		ListView lv = (ListView) layout.findViewById(android.R.id.list);
 		ViewGroup parent = (ViewGroup) lv.getParent();
 
-		// Iterate through parent's children until we find the ListView, we need
-		// to do it this way as we need to find out the child index
-		for (int i = 0, z = parent.getChildCount(); i < z; i++) {
-			View child = parent.getChildAt(i);
-
-			if (child == lv) {
-				// Remove the ListView first
-				parent.removeViewAt(i);
-
-				// Now create ListView, and add it in it's place...
-				mPullToRefreshListView = onCreatePullToRefreshListView(inflater, savedInstanceState);
-				parent.addView(mPullToRefreshListView, i, lv.getLayoutParams());
-				break;
-			}
-		}
+        //Remove ListView and add PullToRefreshListView in its place
+        int lvIndex = parent.indexOfChild(lv);
+        parent.removeViewAt(lvIndex);
+        mPullToRefreshListView = onCreatePullToRefreshListView(inflater, savedInstanceState);
+        parent.addView(mPullToRefreshListView, lvIndex, lv.getLayoutParams());
 
 		return layout;
 	}
