Wrapping exceptions at startup with StartupException.

imeszaros · imeszaros · commit 600769d73404 · 2020-11-11T18:20:06.000+01:00
diff --git a/jooby/src/main/java/io/jooby/Jooby.java b/jooby/src/main/java/io/jooby/Jooby.java
@@ -7,6 +7,7 @@
 
 import com.typesafe.config.Config;
 import io.jooby.exception.RegistryException;
+import io.jooby.exception.StartupException;
 import io.jooby.internal.LocaleUtils;
 import io.jooby.internal.RouterImpl;
 import org.slf4j.Logger;
@@ -724,7 +725,7 @@ public Jooby errorCode(@Nonnull Class<? extends Throwable> type,
         log.info("Server stop resulted in exception", stopx);
       }
       // rethrow
-      throw SneakyThrows.propagate(x);
+      throw new StartupException("Application startup resulted in exception", x);
     }
   }
 
@@ -1047,7 +1048,7 @@ public static Jooby createApp(@Nonnull String[] args, @Nonnull ExecutionMode exe
       LoggerFactory.getLogger(Jooby.class)
           .error("Application initialization resulted in exception", t);
 
-      throw t;
+      throw new StartupException("Application initialization resulted in exception", t);
     }
 
     if (app.mode == null) {
diff --git a/jooby/src/main/java/io/jooby/exception/StartupException.java b/jooby/src/main/java/io/jooby/exception/StartupException.java
@@ -0,0 +1,18 @@
+package io.jooby.exception;
+
+/**
+ * Thrown when Jooby was unable to initialize and start
+ * an application up.
+ */
+public class StartupException extends RuntimeException {
+
+  /**
+   * Creates a new instance of this class with the specified message and cause.
+   *
+   * @param message The message
+   * @param cause The cause
+   */
+  public StartupException(String message, Throwable cause) {
+    super(message, cause);
+  }
+}
diff --git a/tests/src/test/java/io/jooby/Issue2107.java b/tests/src/test/java/io/jooby/Issue2107.java
@@ -4,10 +4,12 @@
 import ch.qos.logback.classic.Logger;
 import ch.qos.logback.classic.spi.ILoggingEvent;
 import ch.qos.logback.core.read.ListAppender;
+import io.jooby.exception.StartupException;
 import org.junit.jupiter.api.Test;
 import org.slf4j.LoggerFactory;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public class Issue2107 {
@@ -19,8 +21,10 @@ public void appInitExceptionLogging() {
     appender.start();
     log.addAppender(appender);
 
-    Throwable t = assertThrows(RuntimeException.class, () -> Jooby.runApp(new String[0], App::new));
-    assertEquals("meh", t.getMessage());
+    Throwable t = assertThrows(StartupException.class, () -> Jooby.runApp(new String[0], App::new));
+    assertEquals("Application initialization resulted in exception", t.getMessage());
+    assertNotNull(t.getCause());
+    assertEquals("meh", t.getCause().getMessage());
     assertEquals(1, appender.list.size());
 
     final ILoggingEvent ev = appender.list.get(0);

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`
`8`	`8`	`import com.typesafe.config.Config;`
`9`	`9`	`import io.jooby.exception.RegistryException;`
	`10`	`+import io.jooby.exception.StartupException;`
`10`	`11`	`import io.jooby.internal.LocaleUtils;`
`11`	`12`	`import io.jooby.internal.RouterImpl;`
`12`	`13`	`import org.slf4j.Logger;`
`@@ -724,7 +725,7 @@ public Jooby errorCode(@Nonnull Class<? extends Throwable> type,`
`724`	`725`	`log.info("Server stop resulted in exception", stopx);`
`725`	`726`	`}`
`726`	`727`	`// rethrow`
`727`		`- throw SneakyThrows.propagate(x);`
	`728`	`+ throw new StartupException("Application startup resulted in exception", x);`
`728`	`729`	`}`
`729`	`730`	`}`
`730`	`731`
`@@ -1047,7 +1048,7 @@ public static Jooby createApp(@Nonnull String[] args, @Nonnull ExecutionMode exe`
`1047`	`1048`	`LoggerFactory.getLogger(Jooby.class)`
`1048`	`1049`	`.error("Application initialization resulted in exception", t);`
`1049`	`1050`
`1050`		`- throw t;`
	`1051`	`+ throw new StartupException("Application initialization resulted in exception", t);`
`1051`	`1052`	`}`
`1052`	`1053`
`1053`	`1054`	`if (app.mode == null) {`