Skip to content

[pull] develop from mikepenz:develop - #23

Open
pull[bot] wants to merge 17 commits into
httpsgithu:developfrom
mikepenz:develop
Open

pull[bot] wants to merge 17 commits into
httpsgithu:developfrom
mikepenz:develop

Conversation

@pull

@pull pull Bot commented Sep 30, 2022 •

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

mikepenz and others added 6 commits September 30, 2022 10:05
Fix crash if `FilterResults` contain `null` values
```
gradle 7.5.1
gradle tools 7.3.0
compile / target 33
build tools 33
material 1.6.1
appcompat 1.5.1
kotlin 1.7.20
materialdrawer 9.0.1
aboutlib 10.5.0
roboelectric 4.8.2
room 2.4.3
```

- drop mopub samples - please see older releases on how these usecases were achieved.
…0220930

Upgrade dependencies to latest version | Kotlin 1.7.20
@pull pull Bot added the ⤵️ pull label Sep 30, 2022
mikepenz and others added 11 commits October 14, 2022 10:20
Drop `network_security_config` from sample app
Bumps [git](https://github.com/ruby-git/ruby-git) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ruby-git/ruby-git/releases)
- [Changelog](https://github.com/ruby-git/ruby-git/blob/master/CHANGELOG.md)
- [Commits](ruby-git/ruby-git@v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: git
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
- Bump actions, some of them are deprecated.
- Use more [gradle/gradle-build-action@v2](https://github.com/gradle/gradle-build-action) to cache Gradle.
- Upload Android lint results via github/codeql-action/upload-sarif
- Replace Danger-based PR checks with a direct github-script PR quality gate workflow
- Modernize CI action versions (checkout@v6, setup-java@v5 with JDK 17/21, gradle/actions@v6, upload-artifact@v7)
- Enable sarifReport in lintOptions for all Android subprojects
- Remove Dangerfile, Gemfile, Gemfile.lock

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Gradle 7.5.1 doesn't support Java 21, so the build was failing because
setup-java made JAVA_HOME point at JDK 21. Pin to JDK 17.

Also broaden the SARIF find pattern to match any lint-results*.sarif
under build/reports, and only run upload-sarif when at least one file
was collected (so the step doesn't fail noisily on empty input).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Make SARIF collection resilient by also running on lint failure
  (success() || failure()) and gating upload on actual file presence
- Skip SARIF upload for forked PRs where security-events:write is not
  granted, so external contributor PRs aren't broken
- Trigger pr-checks workflow on labeled/unlabeled/edited so DO NOT MERGE
  / WIP gates can't be bypassed by editing the PR after the last push

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
GitHub Code Scanning rejects multiple SARIF runs uploaded under the
same category in a single call. Switch to one upload-sarif step per
Android module with a module-scoped category, gated by hashFiles so
the step is skipped when a module produced no SARIF report.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ci: migrate lint reporting to SARIF and remove Danger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants