Annotate a few more null assignments

mjbvz · mjbvz · commit ffbe67fef405 · 2018-10-11T16:45:05.000-07:00
diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -132,6 +132,7 @@
 		"./vs/editor/common/modes/languageConfigurationRegistry.ts",
 		"./vs/editor/common/modes/languageFeatureRegistry.ts",
 		"./vs/editor/common/modes/languageSelector.ts",
+		"./vs/editor/common/modes/linkComputer.ts",
 		"./vs/editor/common/modes/nullMode.ts",
 		"./vs/editor/common/modes/supports.ts",
 		"./vs/editor/common/modes/supports/characterPair.ts",
diff --git a/src/vs/editor/browser/view/viewOutgoingEvents.ts b/src/vs/editor/browser/view/viewOutgoingEvents.ts
@@ -19,18 +19,18 @@ export interface EventCallback<T> {
 
 export class ViewOutgoingEvents extends Disposable {
 
-	public onDidScroll: EventCallback<IScrollEvent> = null;
-	public onDidGainFocus: EventCallback<void> = null;
-	public onDidLoseFocus: EventCallback<void> = null;
-	public onKeyDown: EventCallback<IKeyboardEvent> = null;
-	public onKeyUp: EventCallback<IKeyboardEvent> = null;
-	public onContextMenu: EventCallback<IEditorMouseEvent> = null;
-	public onMouseMove: EventCallback<IEditorMouseEvent> = null;
-	public onMouseLeave: EventCallback<IEditorMouseEvent> = null;
-	public onMouseUp: EventCallback<IEditorMouseEvent> = null;
-	public onMouseDown: EventCallback<IEditorMouseEvent> = null;
-	public onMouseDrag: EventCallback<IEditorMouseEvent> = null;
-	public onMouseDrop: EventCallback<IEditorMouseEvent> = null;
+	public onDidScroll: EventCallback<IScrollEvent> | null = null;
+	public onDidGainFocus: EventCallback<void> | null = null;
+	public onDidLoseFocus: EventCallback<void> | null = null;
+	public onKeyDown: EventCallback<IKeyboardEvent> | null = null;
+	public onKeyUp: EventCallback<IKeyboardEvent> | null = null;
+	public onContextMenu: EventCallback<IEditorMouseEvent> | null = null;
+	public onMouseMove: EventCallback<IEditorMouseEvent> | null = null;
+	public onMouseLeave: EventCallback<IEditorMouseEvent> | null = null;
+	public onMouseUp: EventCallback<IEditorMouseEvent> | null = null;
+	public onMouseDown: EventCallback<IEditorMouseEvent> | null = null;
+	public onMouseDrag: EventCallback<IEditorMouseEvent> | null = null;
+	public onMouseDrop: EventCallback<IEditorMouseEvent> | null = null;
 
 	private _viewModel: IViewModel;
 
diff --git a/src/vs/editor/common/modes/linkComputer.ts b/src/vs/editor/common/modes/linkComputer.ts
@@ -123,7 +123,7 @@ const enum CharacterClass {
 	CannotEndIn = 2
 }
 
-let _classifier: CharacterClassifier<CharacterClass> = null;
+let _classifier: CharacterClassifier<CharacterClass> | null = null;
 function getClassifier(): CharacterClassifier<CharacterClass> {
 	if (_classifier === null) {
 		_classifier = new CharacterClassifier<CharacterClass>(CharacterClass.None);
diff --git a/src/vs/editor/standalone/test/browser/standaloneLanguages.test.ts b/src/vs/editor/standalone/test/browser/standaloneLanguages.test.ts
@@ -56,7 +56,7 @@ suite('TokenizationSupport2Adapter', () => {
 				}
 			};
 		}
-		public readonly onThemeChange: Event<ITheme> = null;
+		public readonly onThemeChange: Event<ITheme> | null = null;
 	}
 
 	class MockState implements IState {
diff --git a/src/vs/workbench/parts/debug/node/terminals.ts b/src/vs/workbench/parts/debug/node/terminals.ts
@@ -29,7 +29,7 @@ export function getTerminalLauncher() {
 	return terminalLauncher;
 }
 
-let _DEFAULT_TERMINAL_LINUX_READY: TPromise<string> = null;
+let _DEFAULT_TERMINAL_LINUX_READY: TPromise<string> | null = null;
 export function getDefaultTerminalLinuxReady(): TPromise<string> {
 	if (!_DEFAULT_TERMINAL_LINUX_READY) {
 		_DEFAULT_TERMINAL_LINUX_READY = new Promise<string>(c => {
diff --git a/src/vs/workbench/parts/emmet/electron-browser/emmetActions.ts b/src/vs/workbench/parts/emmet/electron-browser/emmetActions.ts
@@ -65,7 +65,7 @@ export abstract class EmmetEditorAction extends EditorAction {
 
 	private static readonly emmetSupportedModes = ['html', 'css', 'xml', 'xsl', 'haml', 'jade', 'jsx', 'slim', 'scss', 'sass', 'less', 'stylus', 'styl', 'svg'];
 
-	private _lastGrammarContributions: TPromise<GrammarContributions> = null;
+	private _lastGrammarContributions: TPromise<GrammarContributions> | null = null;
 	private _lastExtensionService: IExtensionService | null = null;
 	private _withGrammarContributions(extensionService: IExtensionService): TPromise<GrammarContributions> {
 		if (this._lastExtensionService !== extensionService) {
diff --git a/src/vs/workbench/parts/execution/electron-browser/terminal.ts b/src/vs/workbench/parts/execution/electron-browser/terminal.ts
@@ -6,7 +6,7 @@
 import * as env from 'vs/base/common/platform';
 import * as pfs from 'vs/base/node/pfs';
 
-let _DEFAULT_TERMINAL_LINUX_READY: Promise<string> = null;
+let _DEFAULT_TERMINAL_LINUX_READY: Promise<string> | null = null;
 export function getDefaultTerminalLinuxReady(): Promise<string> {
 	if (!_DEFAULT_TERMINAL_LINUX_READY) {
 		_DEFAULT_TERMINAL_LINUX_READY = new Promise<string>(c => {

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ const enum CharacterClass {`
`123`	`123`	`CannotEndIn = 2`
`124`	`124`	`}`
`125`	`125`
`126`		`-let _classifier: CharacterClassifier<CharacterClass> = null;`
	`126`	`+let _classifier: CharacterClassifier<CharacterClass> \| null = null;`
`127`	`127`	`function getClassifier(): CharacterClassifier<CharacterClass> {`
`128`	`128`	`if (_classifier === null) {`
`129`	`129`	`_classifier = new CharacterClassifier<CharacterClass>(CharacterClass.None);`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ suite('TokenizationSupport2Adapter', () => {`
`56`	`56`	`}`
`57`	`57`	`};`
`58`	`58`	`}`
`59`		`- public readonly onThemeChange: Event<ITheme> = null;`
	`59`	`+ public readonly onThemeChange: Event<ITheme> \| null = null;`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`class MockState implements IState {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export function getTerminalLauncher() {`
`29`	`29`	`return terminalLauncher;`
`30`	`30`	`}`
`31`	`31`
`32`		`-let _DEFAULT_TERMINAL_LINUX_READY: TPromise<string> = null;`
	`32`	`+let _DEFAULT_TERMINAL_LINUX_READY: TPromise<string> \| null = null;`
`33`	`33`	`export function getDefaultTerminalLinuxReady(): TPromise<string> {`
`34`	`34`	`if (!_DEFAULT_TERMINAL_LINUX_READY) {`
`35`	`35`	`_DEFAULT_TERMINAL_LINUX_READY = new Promise<string>(c => {`