Use 'as const' instead of readonly class object

mjbvz · mjbvz · commit fdeb9aa9b830 · 2019-11-07T20:31:32.000-08:00
diff --git a/extensions/typescript-language-features/src/typescriptService.ts b/extensions/typescript-language-features/src/typescriptService.ts
@@ -21,7 +21,7 @@ export namespace ServerResponse {
 		) { }
 	}
 
-	export const NoContent = new class { readonly type = 'noContent'; };
+	export const NoContent = { type: 'noContent' } as const;
 
 	export type Response<T extends Proto.Response> = T | Cancelled | typeof NoContent;
 }
diff --git a/extensions/typescript-language-features/src/typescriptServiceClient.ts b/extensions/typescript-language-features/src/typescriptServiceClient.ts
@@ -47,7 +47,7 @@ namespace ServerState {
 		Errored
 	}
 
-	export const None = new class { readonly type = Type.None; };
+	export const None = { type: Type.None } as const;
 
 	export class Running {
 		readonly type = Type.Running;
diff --git a/src/vs/editor/contrib/codeAction/codeActionModel.ts b/src/vs/editor/contrib/codeAction/codeActionModel.ts
@@ -141,7 +141,7 @@ export namespace CodeActionsState {
 		Triggered,
 	}
 
-	export const Empty = new class { readonly type = Type.Empty; };
+	export const Empty = { type: Type.Empty } as const;
 
 	export class Triggered {
 		readonly type = Type.Triggered;
diff --git a/src/vs/editor/contrib/codeAction/lightBulbWidget.ts b/src/vs/editor/contrib/codeAction/lightBulbWidget.ts
@@ -25,7 +25,7 @@ namespace LightBulbState {
 		Showing,
 	}
 
-	export const Hidden = new class { readonly type = Type.Hidden; };
+	export const Hidden = { type: Type.Hidden } as const;
 
 	export class Showing {
 		readonly type = Type.Showing;
diff --git a/src/vs/editor/contrib/parameterHints/parameterHintsModel.ts b/src/vs/editor/contrib/parameterHints/parameterHintsModel.ts
@@ -26,7 +26,7 @@ namespace ParameterHintState {
 		Pending,
 	}
 
-	export const Default = new class { readonly type = Type.Default; };
+	export const Default = { type: Type.Default } as const;
 
 	export class Pending {
 		readonly type = Type.Pending;
diff --git a/src/vs/workbench/services/progress/browser/progressIndicator.ts b/src/vs/workbench/services/progress/browser/progressIndicator.ts
@@ -117,9 +117,9 @@ namespace ProgressIndicatorState {
 		Work
 	}
 
-	export const None = new class { readonly type = Type.None; };
-	export const Done = new class { readonly type = Type.Done; };
-	export const Infinite = new class { readonly type = Type.Infinite; };
+	export const None = { type: Type.None } as const;
+	export const Done = { type: Type.Done } as const;
+	export const Infinite = { type: Type.Infinite } as const;
 
 	export class While {
 		readonly type = Type.While;

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ export namespace ServerResponse {`
`21`	`21`	`) { }`
`22`	`22`	`}`
`23`	`23`
`24`		`- export const NoContent = new class { readonly type = 'noContent'; };`
	`24`	`+ export const NoContent = { type: 'noContent' } as const;`
`25`	`25`
`26`	`26`	`export type Response<T extends Proto.Response> = T \| Cancelled \| typeof NoContent;`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ namespace ServerState {`
`47`	`47`	`Errored`
`48`	`48`	`}`
`49`	`49`
`50`		`- export const None = new class { readonly type = Type.None; };`
	`50`	`+ export const None = { type: Type.None } as const;`
`51`	`51`
`52`	`52`	`export class Running {`
`53`	`53`	`readonly type = Type.Running;`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ export namespace CodeActionsState {`
`141`	`141`	`Triggered,`
`142`	`142`	`}`
`143`	`143`
`144`		`- export const Empty = new class { readonly type = Type.Empty; };`
	`144`	`+ export const Empty = { type: Type.Empty } as const;`
`145`	`145`
`146`	`146`	`export class Triggered {`
`147`	`147`	`readonly type = Type.Triggered;`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ namespace LightBulbState {`
`25`	`25`	`Showing,`
`26`	`26`	`}`
`27`	`27`
`28`		`- export const Hidden = new class { readonly type = Type.Hidden; };`
	`28`	`+ export const Hidden = { type: Type.Hidden } as const;`
`29`	`29`
`30`	`30`	`export class Showing {`
`31`	`31`	`readonly type = Type.Showing;`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ namespace ParameterHintState {`
`26`	`26`	`Pending,`
`27`	`27`	`}`
`28`	`28`
`29`		`- export const Default = new class { readonly type = Type.Default; };`
	`29`	`+ export const Default = { type: Type.Default } as const;`
`30`	`30`
`31`	`31`	`export class Pending {`
`32`	`32`	`readonly type = Type.Pending;`