Update behavior of task reveal === silent (microsoft#61477)

alexr00 · web-flow · commit fd5d3ca54e77 · 2018-10-29T12:37:49.000+01:00
When task reveal is set to silent, only show the terminal if the exit code is not 0 or if there are poblem matches Fixes microsoft#41671
diff --git a/src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts b/src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts
@@ -339,7 +339,7 @@ export class TerminalTaskSystem implements ITaskSystem {
 						this._onDidStateChange.fire(TaskEvent.create(TaskEventKind.Inactive, task));
 						if (eventCounter === 0) {
 							let reveal = task.command.presentation.reveal;
-							if (reveal === RevealKind.Silent && watchingProblemMatcher.numberOfMatches > 0 && watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error) {
+							if ((reveal === RevealKind.Silent) && (watchingProblemMatcher.numberOfMatches > 0) && (watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error)) {
 								this.terminalService.setActiveInstance(terminal);
 								this.terminalService.showPanel(false);
 							}
@@ -388,7 +388,7 @@ export class TerminalTaskSystem implements ITaskSystem {
 							break;
 					}
 					let reveal = task.command.presentation.reveal;
-					if (reveal === RevealKind.Silent && (exitCode !== 0 || watchingProblemMatcher.numberOfMatches > 0 && watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error)) {
+					if ((reveal === RevealKind.Silent) && ((exitCode !== 0) || (watchingProblemMatcher.numberOfMatches > 0) && (watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error))) {
 						this.terminalService.setActiveInstance(terminal);
 						this.terminalService.showPanel(false);
 					}
@@ -450,7 +450,7 @@ export class TerminalTaskSystem implements ITaskSystem {
 							break;
 					}
 					let reveal = task.command.presentation.reveal;
-					if (reveal === RevealKind.Silent && (exitCode !== 0 || startStopProblemMatcher.numberOfMatches > 0 && startStopProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error)) {
+					if ((reveal === RevealKind.Silent) && ((exitCode !== 0) || (startStopProblemMatcher.numberOfMatches > 0) && (startStopProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error))) {
 						this.terminalService.setActiveInstance(terminal);
 						this.terminalService.showPanel(false);
 					}
@@ -474,7 +474,7 @@ export class TerminalTaskSystem implements ITaskSystem {
 		if (!terminal) {
 			return TPromise.wrapError<ITaskSummary>(new Error(`Failed to create terminal for task ${task._label}`));
 		}
-		if (task.command.presentation.reveal === RevealKind.Always || (task.command.presentation.reveal === RevealKind.Silent && task.problemMatchers.length === 0)) {
+		if (task.command.presentation.reveal === RevealKind.Always) {
 			this.terminalService.setActiveInstance(terminal);
 			this.terminalService.showPanel(task.command.presentation.focus);
 		}

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ export class TerminalTaskSystem implements ITaskSystem {`
`339`	`339`	`this._onDidStateChange.fire(TaskEvent.create(TaskEventKind.Inactive, task));`
`340`	`340`	`if (eventCounter === 0) {`
`341`	`341`	`let reveal = task.command.presentation.reveal;`
`342`		`- if (reveal === RevealKind.Silent && watchingProblemMatcher.numberOfMatches > 0 && watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error) {`
	`342`	`+ if ((reveal === RevealKind.Silent) && (watchingProblemMatcher.numberOfMatches > 0) && (watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error)) {`
`343`	`343`	`this.terminalService.setActiveInstance(terminal);`
`344`	`344`	`this.terminalService.showPanel(false);`
`345`	`345`	`}`
`@@ -388,7 +388,7 @@ export class TerminalTaskSystem implements ITaskSystem {`
`388`	`388`	`break;`
`389`	`389`	`}`
`390`	`390`	`let reveal = task.command.presentation.reveal;`
`391`		`- if (reveal === RevealKind.Silent && (exitCode !== 0 \|\| watchingProblemMatcher.numberOfMatches > 0 && watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error)) {`
	`391`	`+ if ((reveal === RevealKind.Silent) && ((exitCode !== 0) \|\| (watchingProblemMatcher.numberOfMatches > 0) && (watchingProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error))) {`
`392`	`392`	`this.terminalService.setActiveInstance(terminal);`
`393`	`393`	`this.terminalService.showPanel(false);`
`394`	`394`	`}`
`@@ -450,7 +450,7 @@ export class TerminalTaskSystem implements ITaskSystem {`
`450`	`450`	`break;`
`451`	`451`	`}`
`452`	`452`	`let reveal = task.command.presentation.reveal;`
`453`		`- if (reveal === RevealKind.Silent && (exitCode !== 0 \|\| startStopProblemMatcher.numberOfMatches > 0 && startStopProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error)) {`
	`453`	`+ if ((reveal === RevealKind.Silent) && ((exitCode !== 0) \|\| (startStopProblemMatcher.numberOfMatches > 0) && (startStopProblemMatcher.maxMarkerSeverity >= MarkerSeverity.Error))) {`
`454`	`454`	`this.terminalService.setActiveInstance(terminal);`
`455`	`455`	`this.terminalService.showPanel(false);`
`456`	`456`	`}`
`@@ -474,7 +474,7 @@ export class TerminalTaskSystem implements ITaskSystem {`
`474`	`474`	`if (!terminal) {`
`475`	`475`	return TPromise.wrapError<ITaskSummary>(new Error(`Failed to create terminal for task ${task._label}`));
`476`	`476`	`}`
`477`		`- if (task.command.presentation.reveal === RevealKind.Always \|\| (task.command.presentation.reveal === RevealKind.Silent && task.problemMatchers.length === 0)) {`
	`477`	`+ if (task.command.presentation.reveal === RevealKind.Always) {`
`478`	`478`	`this.terminalService.setActiveInstance(terminal);`
`479`	`479`	`this.terminalService.showPanel(task.command.presentation.focus);`
`480`	`480`	`}`