grid: remove orientation from layout call

joaomoreno · joaomoreno · commit fd16e7ccb434 · 2019-11-27T11:37:54.000+01:00
diff --git a/src/vs/base/browser/ui/centered/centeredViewLayout.ts b/src/vs/base/browser/ui/centered/centeredViewLayout.ts
@@ -42,7 +42,7 @@ function toSplitViewView(view: IView, getHeight: () => number): ISplitViewView {
 		get maximumSize() { return view.maximumWidth; },
 		get minimumSize() { return view.minimumWidth; },
 		onDidChange: Event.map(view.onDidChange, e => e && e.width),
-		layout: size => view.layout(size, getHeight(), Orientation.HORIZONTAL)
+		layout: size => view.layout(size, getHeight())
 	};
 }
 
@@ -81,7 +81,7 @@ export class CenteredViewLayout implements IDisposable {
 				this.resizeMargins();
 			}
 		} else {
-			this.view.layout(width, height, Orientation.HORIZONTAL);
+			this.view.layout(width, height);
 		}
 		this.didLayout = true;
 	}
diff --git a/src/vs/base/browser/ui/grid/gridview.ts b/src/vs/base/browser/ui/grid/gridview.ts
@@ -30,7 +30,7 @@ export interface IView {
 	readonly onDidChange: Event<IViewSize | undefined>;
 	readonly priority?: LayoutPriority;
 	readonly snap?: boolean;
-	layout(width: number, height: number, orientation: Orientation): void;
+	layout(width: number, height: number): void;
 	setVisible?(visible: boolean): void;
 }
 
@@ -628,7 +628,7 @@ class LeafNode implements ISplitView, IDisposable {
 
 		this._size = size;
 		this._orthogonalSize = orthogonalSize;
-		this.view.layout(this.width, this.height, orthogonal(this.orientation));
+		this.view.layout(this.width, this.height);
 	}
 
 	setVisible(visible: boolean): void {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ function toSplitViewView(view: IView, getHeight: () => number): ISplitViewView {`
`42`	`42`	`get maximumSize() { return view.maximumWidth; },`
`43`	`43`	`get minimumSize() { return view.minimumWidth; },`
`44`	`44`	`onDidChange: Event.map(view.onDidChange, e => e && e.width),`
`45`		`- layout: size => view.layout(size, getHeight(), Orientation.HORIZONTAL)`
	`45`	`+ layout: size => view.layout(size, getHeight())`
`46`	`46`	`};`
`47`	`47`	`}`
`48`	`48`
`@@ -81,7 +81,7 @@ export class CenteredViewLayout implements IDisposable {`
`81`	`81`	`this.resizeMargins();`
`82`	`82`	`}`
`83`	`83`	`} else {`
`84`		`- this.view.layout(width, height, Orientation.HORIZONTAL);`
	`84`	`+ this.view.layout(width, height);`
`85`	`85`	`}`
`86`	`86`	`this.didLayout = true;`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ export interface IView {`
`30`	`30`	`readonly onDidChange: Event<IViewSize \| undefined>;`
`31`	`31`	`readonly priority?: LayoutPriority;`
`32`	`32`	`readonly snap?: boolean;`
`33`		`- layout(width: number, height: number, orientation: Orientation): void;`
	`33`	`+ layout(width: number, height: number): void;`
`34`	`34`	`setVisible?(visible: boolean): void;`
`35`	`35`	`}`
`36`	`36`
`@@ -628,7 +628,7 @@ class LeafNode implements ISplitView, IDisposable {`
`628`	`628`
`629`	`629`	`this._size = size;`
`630`	`630`	`this._orthogonalSize = orthogonalSize;`
`631`		`- this.view.layout(this.width, this.height, orthogonal(this.orientation));`
	`631`	`+ this.view.layout(this.width, this.height);`
`632`	`632`	`}`
`633`	`633`
`634`	`634`	`setVisible(visible: boolean): void {`