electron - always go through window#focus()

Benjamin Pasero · Benjamin Pasero · commit fa96b9c82fb2 · 2020-06-24T09:44:42.000+02:00
diff --git a/src/vs/platform/electron/electron-main/electronMainService.ts b/src/vs/platform/electron/electron-main/electronMainService.ts
@@ -179,11 +179,7 @@ export class ElectronMainService implements IElectronMainService {
 
 		const window = this.windowById(windowId);
 		if (window) {
-			if (isMacintosh) {
-				window.win.show();
-			} else {
-				window.win.focus();
-			}
+			window.focus();
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -179,11 +179,7 @@ export class ElectronMainService implements IElectronMainService {`
`179`	`179`
`180`	`180`	`const window = this.windowById(windowId);`
`181`	`181`	`if (window) {`
`182`		`- if (isMacintosh) {`
`183`		`- window.win.show();`
`184`		`- } else {`
`185`		`- window.win.focus();`
`186`		`- }`
	`182`	`+ window.focus();`
`187`	`183`	`}`
`188`	`184`	`}`
`189`	`185`