Skip to content

Commit f94cea3

Browse files
mjbvzmjbvz
committed
Mark private emitters as readonly
1 parent adcf6b2 commit f94cea3

93 files changed

Lines changed: 214 additions & 214 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/vs/base/browser/browser.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class WindowManager {
1515
// --- Zoom Level
1616
private _zoomLevel: number = 0;
1717
private _lastZoomLevelChangeTime: number = 0;
18-
private _onDidChangeZoomLevel: Emitter<number> = new Emitter<number>();
18+
private readonly _onDidChangeZoomLevel: Emitter<number> = new Emitter<number>();
1919

2020
public readonly onDidChangeZoomLevel: Event<number> = this._onDidChangeZoomLevel.event;
2121
public getZoomLevel(): number {
@@ -61,7 +61,7 @@ class WindowManager {
6161

6262
// --- Fullscreen
6363
private _fullscreen: boolean;
64-
private _onDidChangeFullscreen: Emitter<void> = new Emitter<void>();
64+
private readonly _onDidChangeFullscreen: Emitter<void> = new Emitter<void>();
6565

6666
public readonly onDidChangeFullscreen: Event<void> = this._onDidChangeFullscreen.event;
6767
public setFullscreen(fullscreen: boolean): void {
@@ -78,7 +78,7 @@ class WindowManager {
7878

7979
// --- Accessibility
8080
private _accessibilitySupport = Platform.AccessibilitySupport.Unknown;
81-
private _onDidChangeAccessibilitySupport: Emitter<void> = new Emitter<void>();
81+
private readonly _onDidChangeAccessibilitySupport: Emitter<void> = new Emitter<void>();
8282

8383
public readonly onDidChangeAccessibilitySupport: Event<void> = this._onDidChangeAccessibilitySupport.event;
8484
public setAccessibilitySupport(accessibilitySupport: Platform.AccessibilitySupport): void {

‎src/vs/base/browser/ui/sash/sash.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ export class VSash extends Disposable implements IVerticalSashLayoutProvider {
301301
private position: number;
302302
private dimension: Dimension;
303303

304-
private _onPositionChange: Emitter<number> = new Emitter<number>();
304+
private readonly _onPositionChange: Emitter<number> = new Emitter<number>();
305305
public get onPositionChange(): Event<number> { return this._onPositionChange.event; }
306306

307307
constructor(container: HTMLElement, private minWidth: number) {

‎src/vs/base/browser/ui/selectBox/selectBoxCustom.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class SelectBoxList implements ISelectBoxDelegate, IDelegate<ISelectOptio
7878
private options: string[];
7979
private selected: number;
8080
private disabledOptionIndex: number;
81-
private _onDidSelect: Emitter<ISelectData>;
81+
private readonly _onDidSelect: Emitter<ISelectData>;
8282
private toDispose: IDisposable[];
8383
private styles: ISelectBoxStyles;
8484
private listRenderer: SelectListRenderer;

‎src/vs/base/browser/ui/selectBox/selectBoxNative.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export class SelectBoxNative implements ISelectBoxDelegate {
1616
private selectElement: HTMLSelectElement;
1717
private options: string[];
1818
private selected: number;
19-
private _onDidSelect: Emitter<ISelectData>;
19+
private readonly _onDidSelect: Emitter<ISelectData>;
2020
private toDispose: IDisposable[];
2121
private styles: ISelectBoxStyles;
2222

‎src/vs/base/common/async.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ export class Limiter<T> {
424424
private runningPromises: number;
425425
private maxDegreeOfParalellism: number;
426426
private outstandingPromises: ILimitedTaskFactory[];
427-
private _onFinished: Emitter<void>;
427+
private readonly _onFinished: Emitter<void>;
428428

429429
constructor(maxDegreeOfParalellism: number) {
430430
this.maxDegreeOfParalellism = maxDegreeOfParalellism;

‎src/vs/base/common/event.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ export class Emitter<T> {
163163

164164
export class EventMultiplexer<T> implements IDisposable {
165165

166-
private emitter: Emitter<T>;
166+
private readonly emitter: Emitter<T>;
167167
private hasListeners = false;
168168
private events: { event: Event<T>; listener: IDisposable; }[] = [];
169169

‎src/vs/base/node/config.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export class ConfigWatcher<T> implements IConfigWatcher<T>, IDisposable {
5050
private loaded: boolean;
5151
private timeoutHandle: NodeJS.Timer;
5252
private disposables: IDisposable[];
53-
private _onDidUpdateConfiguration: Emitter<IConfigurationChangeEvent<T>>;
53+
private readonly _onDidUpdateConfiguration: Emitter<IConfigurationChangeEvent<T>>;
5454
private configName: string;
5555

5656
constructor(private _path: string, private options: IConfigOptions<T> = { changeBufferDelay: 0, defaultConfig: Object.create(null), onError: error => console.error(error) }) {

‎src/vs/base/parts/tree/browser/treeView.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -440,10 +440,10 @@ export class TreeView extends HeightMap {
440440
private highlightedItemWasDraggable: boolean;
441441
private onHiddenScrollTop: number;
442442

443-
private _onDOMFocus: Emitter<void> = new Emitter<void>();
443+
private readonly _onDOMFocus: Emitter<void> = new Emitter<void>();
444444
get onDOMFocus(): Event<void> { return this._onDOMFocus.event; }
445445

446-
private _onDOMBlur: Emitter<void> = new Emitter<void>();
446+
private readonly _onDOMBlur: Emitter<void> = new Emitter<void>();
447447
get onDOMBlur(): Event<void> { return this._onDOMBlur.event; }
448448

449449
constructor(context: _.ITreeContext, container: HTMLElement) {

‎src/vs/code/electron-main/keyboard.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class KeyboardLayoutMonitor {
2020

2121
public static readonly INSTANCE = new KeyboardLayoutMonitor();
2222

23-
private _emitter: Emitter<void>;
23+
private readonly _emitter: Emitter<void>;
2424
private _registered: boolean;
2525

2626
private constructor() {

‎src/vs/editor/browser/services/abstractCodeEditorService.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ export abstract class AbstractCodeEditorService implements ICodeEditorService {
1414

1515
_serviceBrand: any;
1616

17-
private _onCodeEditorAdd: Emitter<ICodeEditor>;
18-
private _onCodeEditorRemove: Emitter<ICodeEditor>;
17+
private readonly _onCodeEditorAdd: Emitter<ICodeEditor>;
18+
private readonly _onCodeEditorRemove: Emitter<ICodeEditor>;
1919
private _codeEditors: { [editorId: string]: ICodeEditor; };
2020

21-
private _onDiffEditorAdd: Emitter<IDiffEditor>;
22-
private _onDiffEditorRemove: Emitter<IDiffEditor>;
21+
private readonly _onDiffEditorAdd: Emitter<IDiffEditor>;
22+
private readonly _onDiffEditorRemove: Emitter<IDiffEditor>;
2323
private _diffEditors: { [editorId: string]: IDiffEditor; };
2424

2525
constructor() {

0 commit comments

Comments
 (0)