Fix suppressImplicitAnyIndexErrors false in externalTerminal

Tyriar · Tyriar · commit f7c692ab4cfb · 2019-07-03T10:14:40.000-07:00
Part of microsoft#76442
diff --git a/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts b/src/vs/workbench/contrib/externalTerminal/node/externalTerminalService.ts
@@ -326,7 +326,7 @@ export class LinuxExternalTerminalService implements IExternalTerminalService {
  * tries to turn OS errors into more meaningful error messages
  */
 function improveError(err: Error): Error {
-	if (err['errno'] === 'ENOENT' && err['path']) {
+	if ('errno' in err && err['errno'] === 'ENOENT' && 'path' in err && typeof err['path'] === 'string') {
 		return new Error(nls.localize('ext.term.app.not.found', "can't find terminal application '{0}'", err['path']));
 	}
 	return err;

Original file line number	Diff line number	Diff line change
`@@ -326,7 +326,7 @@ export class LinuxExternalTerminalService implements IExternalTerminalService {`
`326`	`326`	`* tries to turn OS errors into more meaningful error messages`
`327`	`327`	`*/`
`328`	`328`	`function improveError(err: Error): Error {`
`329`		`- if (err['errno'] === 'ENOENT' && err['path']) {`
	`329`	`+ if ('errno' in err && err['errno'] === 'ENOENT' && 'path' in err && typeof err['path'] === 'string') {`
`330`	`330`	`return new Error(nls.localize('ext.term.app.not.found', "can't find terminal application '{0}'", err['path']));`
`331`	`331`	`}`
`332`	`332`	`return err;`