Fixing/supressing more implictIndex errors

mjbvz · mjbvz · commit f7a36ce0b9cf · 2019-07-02T15:02:50.000-07:00
microsoft#76442
diff --git a/src/vs/base/test/common/decorators.test.ts b/src/vs/base/test/common/decorators.test.ts
@@ -119,7 +119,7 @@ suite('Decorators', () => {
 		assert.equal(foo.answer, 42);
 
 		try {
-			foo['$memoize$answer'] = 1337;
+			(foo as any)['$memoize$answer'] = 1337;
 			assert(false);
 		} catch (e) {
 			assert.equal(foo.answer, 42);
diff --git a/src/vs/editor/contrib/colorPicker/colorDetector.ts b/src/vs/editor/contrib/colorPicker/colorDetector.ts
@@ -78,7 +78,7 @@ export class ColorDetector extends Disposable implements IEditorContribution {
 		// handle deprecated settings. [languageId].colorDecorators.enable
 		const deprecatedConfig = this._configurationService.getValue<{}>(languageId.language);
 		if (deprecatedConfig) {
-			const colorDecorators = deprecatedConfig['colorDecorators']; // deprecatedConfig.valueOf('.colorDecorators.enable');
+			const colorDecorators = (deprecatedConfig as any)['colorDecorators']; // deprecatedConfig.valueOf('.colorDecorators.enable');
 			if (colorDecorators && colorDecorators['enable'] !== undefined && !colorDecorators['enable']) {
 				return colorDecorators['enable'];
 			}
diff --git a/src/vs/platform/environment/node/argv.ts b/src/vs/platform/environment/node/argv.ts
@@ -121,8 +121,8 @@ export function parseArgs(args: string[], isOptionSupported = (_: Option) => tru
 		}
 	}
 	// remote aliases to avoid confusion
-	const parsedArgs = minimist(args, { string, boolean, alias }) as ParsedArgs;
-	for (let o of options) {
+	const parsedArgs = minimist(args, { string, boolean, alias });
+	for (const o of options) {
 		if (o.alias) {
 			delete parsedArgs[o.alias];
 		}
@@ -203,10 +203,10 @@ export function buildHelpMessage(productName: string, executableName: string, ve
 		}
 		help.push('');
 	}
-	for (let key in categories) {
+	for (const key in categories) {
 		let categoryOptions = options.filter(o => !!o.description && o.cat === key && isOptionSupported(o));
 		if (categoryOptions.length) {
-			help.push(categories[key]);
+			help.push(categories[key as keyof HelpCategories]);
 			help.push(...formatOptions(categoryOptions, columns));
 			help.push('');
 		}

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ export class ColorDetector extends Disposable implements IEditorContribution {`
`78`	`78`	`// handle deprecated settings. [languageId].colorDecorators.enable`
`79`	`79`	`const deprecatedConfig = this._configurationService.getValue<{}>(languageId.language);`
`80`	`80`	`if (deprecatedConfig) {`
`81`		`- const colorDecorators = deprecatedConfig['colorDecorators']; // deprecatedConfig.valueOf('.colorDecorators.enable');`
	`81`	`+ const colorDecorators = (deprecatedConfig as any)['colorDecorators']; // deprecatedConfig.valueOf('.colorDecorators.enable');`
`82`	`82`	`if (colorDecorators && colorDecorators['enable'] !== undefined && !colorDecorators['enable']) {`
`83`	`83`	`return colorDecorators['enable'];`
`84`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,8 +121,8 @@ export function parseArgs(args: string[], isOptionSupported = (_: Option) => tru`
`121`	`121`	`}`
`122`	`122`	`}`
`123`	`123`	`// remote aliases to avoid confusion`
`124`		`- const parsedArgs = minimist(args, { string, boolean, alias }) as ParsedArgs;`
`125`		`- for (let o of options) {`
	`124`	`+ const parsedArgs = minimist(args, { string, boolean, alias });`
	`125`	`+ for (const o of options) {`
`126`	`126`	`if (o.alias) {`
`127`	`127`	`delete parsedArgs[o.alias];`
`128`	`128`	`}`
`@@ -203,10 +203,10 @@ export function buildHelpMessage(productName: string, executableName: string, ve`
`203`	`203`	`}`
`204`	`204`	`help.push('');`
`205`	`205`	`}`
`206`		`- for (let key in categories) {`
	`206`	`+ for (const key in categories) {`
`207`	`207`	`let categoryOptions = options.filter(o => !!o.description && o.cat === key && isOptionSupported(o));`
`208`	`208`	`if (categoryOptions.length) {`
`209`		`- help.push(categories[key]);`
	`209`	`+ help.push(categories[key as keyof HelpCategories]);`
`210`	`210`	`help.push(...formatOptions(categoryOptions, columns));`
`211`	`211`	`help.push('');`
`212`	`212`	`}`