Skip to content

Commit f75285a

Browse files
committed
Remove save / state from custom editor api proposal for now
These features are not working in many cases and the api around them will likely change significantly
1 parent 71c95a4 commit f75285a

1 file changed

Lines changed: 0 additions & 38 deletions

File tree

src/vs/vscode.proposed.d.ts

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,45 +1085,7 @@ declare module 'vscode' {
10851085

10861086
//#region Custom editors, mjbvz
10871087

1088-
export enum WebviewContentState {
1089-
/**
1090-
* The webview content cannot be modified.
1091-
*
1092-
* This disables save.
1093-
*/
1094-
Readonly = 1,
1095-
1096-
/**
1097-
* The webview content has not been changed but they can be modified and saved.
1098-
*/
1099-
Unchanged = 2,
1100-
1101-
/**
1102-
* The webview content has been changed and can be saved.
1103-
*/
1104-
Dirty = 3,
1105-
}
1106-
1107-
export interface WebviewEditorState {
1108-
readonly contentState: WebviewContentState;
1109-
}
1110-
1111-
export interface WebviewPanel {
1112-
editorState: WebviewEditorState;
1113-
1114-
/**
1115-
* Fired when the webview is being saved.
1116-
*
1117-
* Both `Unchanged` and `Dirty` editors can be saved.
1118-
*
1119-
* Extensions should call `waitUntil` to signal when the save operation complete
1120-
*/
1121-
readonly onWillSave: Event<{ waitUntil: (thenable: Thenable<boolean>) => void }>;
1122-
}
1123-
11241088
export interface WebviewEditor extends WebviewPanel {
1125-
// TODO: We likely do not want `editorState` and `onWillSave` enabled for
1126-
// resource backed webviews
11271089
}
11281090

11291091
export interface WebviewEditorProvider {

0 commit comments

Comments
 (0)