Fixes microsoft#27844: Task quick selection needs to filter on label

dbaeumer · dbaeumer · commit f6891b951af7 · 2017-06-01T15:02:12.000+02:00
diff --git a/src/vs/workbench/parts/tasks/browser/quickOpen.ts b/src/vs/workbench/parts/tasks/browser/quickOpen.ts
@@ -81,7 +81,7 @@ export abstract class QuickOpenHandler extends Quickopen.QuickOpenHandler {
 							return compare;
 						}
 					}
-					return a.name.localeCompare(b.name);
+					return a._label.localeCompare(b._label);
 				}
 				if (aKind === TaskSourceKind.Workspace) {
 					return -1;
@@ -95,7 +95,7 @@ export abstract class QuickOpenHandler extends Quickopen.QuickOpenHandler {
 			let groupExtension = groupWorkspace;
 			let hadWorkspace = false;
 			for (let task of tasks) {
-				let highlights = Filters.matchesContiguousSubString(input, task.name);
+				let highlights = Filters.matchesContiguousSubString(input, task._label);
 				if (!highlights) {
 					continue;
 				}

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ export abstract class QuickOpenHandler extends Quickopen.QuickOpenHandler {`
`81`	`81`	`return compare;`
`82`	`82`	`}`
`83`	`83`	`}`
`84`		`- return a.name.localeCompare(b.name);`
	`84`	`+ return a._label.localeCompare(b._label);`
`85`	`85`	`}`
`86`	`86`	`if (aKind === TaskSourceKind.Workspace) {`
`87`	`87`	`return -1;`
`@@ -95,7 +95,7 @@ export abstract class QuickOpenHandler extends Quickopen.QuickOpenHandler {`
`95`	`95`	`let groupExtension = groupWorkspace;`
`96`	`96`	`let hadWorkspace = false;`
`97`	`97`	`for (let task of tasks) {`
`98`		`- let highlights = Filters.matchesContiguousSubString(input, task.name);`
	`98`	`+ let highlights = Filters.matchesContiguousSubString(input, task._label);`
`99`	`99`	`if (!highlights) {`
`100`	`100`	`continue;`
`101`	`101`	`}`