electron - allow to configure color profile for microsoft#88491

Benjamin Pasero · Benjamin Pasero · commit f647df6e52b4 · 2020-02-21T08:07:34.000+01:00
diff --git a/src/main.js b/src/main.js
@@ -131,8 +131,12 @@ function configureCommandlineSwitchesSync(cliArgs) {
 		'disable-hardware-acceleration',
 
 		// provided by Electron
-		'disable-color-correct-rendering'
+		'disable-color-correct-rendering',
+
+		// override for the color profile to use
+		'force-color-profile'
 	];
+	
 	if (process.platform === 'linux') {
 		SUPPORTED_ELECTRON_SWITCHES.push('force-renderer-accessibility');
 	}
@@ -147,7 +151,16 @@ function configureCommandlineSwitchesSync(cliArgs) {
 		}
 
 		const argvValue = argvConfig[argvKey];
-		if (argvValue === true || argvValue === 'true') {
+
+		// Color profile
+		if (argvKey === 'force-color-profile') {
+			if (argvValue) {
+				app.commandLine.appendSwitch(argvKey, argvValue);
+			}
+		}
+
+		// Others
+		else if (argvValue === true || argvValue === 'true') {
 			if (argvKey === 'disable-hardware-acceleration') {
 				app.disableHardwareAcceleration(); // needs to be called explicitly
 			} else {
diff --git a/src/vs/workbench/electron-browser/desktop.contribution.ts b/src/vs/workbench/electron-browser/desktop.contribution.ts
@@ -341,6 +341,10 @@ import { IJSONSchema } from 'vs/base/common/jsonSchema';
 			'disable-color-correct-rendering': {
 				type: 'boolean',
 				description: nls.localize('argv.disableColorCorrectRendering', 'Resolves issues around color profile selection. ONLY change this option if you encounter graphic issues.')
+			},
+			'force-color-profile': {
+				type: 'string',
+				markdownDescription: nls.localize('argv.forceColorProfile', 'Allows to override the color profile to use. If you experience colors appear badly, try to set this to `srgb` and restart.')
 			}
 		}
 	};

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,10 @@ import { IJSONSchema } from 'vs/base/common/jsonSchema';`
`341`	`341`	`'disable-color-correct-rendering': {`
`342`	`342`	`type: 'boolean',`
`343`	`343`	`description: nls.localize('argv.disableColorCorrectRendering', 'Resolves issues around color profile selection. ONLY change this option if you encounter graphic issues.')`
	`344`	`+ },`
	`345`	`+ 'force-color-profile': {`
	`346`	`+ type: 'string',`
	`347`	+ markdownDescription: nls.localize('argv.forceColorProfile', 'Allows to override the color profile to use. If you experience colors appear badly, try to set this to `srgb` and restart.')
`344`	`348`	`}`
`345`	`349`	`}`
`346`	`350`	`};`