fix microsoft#61179

jrieken · jrieken · commit f5bfeb734cb0 · 2018-10-18T16:25:09.000+02:00
diff --git a/src/vs/editor/contrib/documentSymbols/outlineModel.ts b/src/vs/editor/contrib/documentSymbols/outlineModel.ts
@@ -133,7 +133,11 @@ export class OutlineGroup extends TreeElement {
 	}
 
 	private _updateMatches(pattern: string, item: OutlineElement, topMatch: OutlineElement): OutlineElement {
-		item.score = fuzzyScore(pattern, pattern.toLowerCase(), 0, item.symbol.name, item.symbol.name.toLowerCase(), 0, true);
+
+		item.score = pattern
+			? fuzzyScore(pattern, pattern.toLowerCase(), 0, item.symbol.name, item.symbol.name.toLowerCase(), 0, true)
+			: [-100, []];
+
 		if (item.score && (!topMatch || item.score[0] > topMatch.score[0])) {
 			topMatch = item;
 		}
@@ -142,7 +146,7 @@ export class OutlineGroup extends TreeElement {
 			topMatch = this._updateMatches(pattern, child, topMatch);
 			if (!item.score && child.score) {
 				// don't filter parents with unfiltered children
-				item.score = [0, []];
+				item.score = [-100, []];
 			}
 		}
 		return topMatch;

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,11 @@ export class OutlineGroup extends TreeElement {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`private _updateMatches(pattern: string, item: OutlineElement, topMatch: OutlineElement): OutlineElement {`
`136`		`- item.score = fuzzyScore(pattern, pattern.toLowerCase(), 0, item.symbol.name, item.symbol.name.toLowerCase(), 0, true);`
	`136`	`+`
	`137`	`+ item.score = pattern`
	`138`	`+ ? fuzzyScore(pattern, pattern.toLowerCase(), 0, item.symbol.name, item.symbol.name.toLowerCase(), 0, true)`
	`139`	`+ : [-100, []];`
	`140`	`+`
`137`	`141`	`if (item.score && (!topMatch \|\| item.score[0] > topMatch.score[0])) {`
`138`	`142`	`topMatch = item;`
`139`	`143`	`}`
`@@ -142,7 +146,7 @@ export class OutlineGroup extends TreeElement {`
`142`	`146`	`topMatch = this._updateMatches(pattern, child, topMatch);`
`143`	`147`	`if (!item.score && child.score) {`
`144`	`148`	`// don't filter parents with unfiltered children`
`145`		`- item.score = [0, []];`
	`149`	`+ item.score = [-100, []];`
`146`	`150`	`}`
`147`	`151`	`}`
`148`	`152`	`return topMatch;`