eng - change --performance into --prof-modules because that's what it is

jrieken · jrieken · commit f57236411380 · 2018-12-28T13:56:34.000+01:00
diff --git a/src/vs/platform/environment/common/environment.ts b/src/vs/platform/environment/common/environment.ts
@@ -25,10 +25,10 @@ export interface ParsedArgs {
 	'reuse-window'?: boolean;
 	locale?: string;
 	'user-data-dir'?: string;
-	performance?: boolean;
 	'prof-startup'?: string;
 	'prof-startup-prefix'?: string;
 	'prof-append-timers'?: string;
+	'prof-modules'?: string;
 	verbose?: boolean;
 	trace?: boolean;
 	'trace-category-filter'?: string;
@@ -126,7 +126,6 @@ export interface IEnvironmentService {
 	isBuilt: boolean;
 	wait: boolean;
 	status: boolean;
-	performance: boolean;
 
 	// logging
 	log?: string;
diff --git a/src/vs/platform/environment/node/argv.ts b/src/vs/platform/environment/node/argv.ts
@@ -51,8 +51,8 @@ const options: minimist.Opts = {
 		'unity-launch',
 		'reuse-window',
 		'open-url',
-		'performance',
 		'prof-startup',
+		'prof-code-loading',
 		'verbose',
 		'logExtensionHostCommunication',
 		'disable-extensions',
@@ -175,8 +175,8 @@ const troubleshootingHelp: { [name: string]: string; } = {
 	'--verbose': localize('verbose', "Print verbose output (implies --wait)."),
 	'--log <level>': localize('log', "Log level to use. Default is 'info'. Allowed values are 'critical', 'error', 'warn', 'info', 'debug', 'trace', 'off'."),
 	'-s, --status': localize('status', "Print process usage and diagnostics information."),
-	'-p, --performance': localize('performance', "Start with the 'Developer: Startup Performance' command enabled."),
-	'--prof-startup': localize('prof-startup', "Run CPU profiler during startup"),
+	'--prof-startup': localize('prof-startup', "Run CPU profilers during startup."),
+	'--prof-modules': localize('prof-modules', "Capture performance markers while loading JS modules and print them with 'F1 > Developer: Startup Performance'"),
 	'--disable-extensions': localize('disableExtensions', "Disable all installed extensions."),
 	'--disable-extension <extension-id>': localize('disableExtension', "Disable an extension."),
 	'--inspect-extensions': localize('inspect-extensions', "Allow debugging and profiling of extensions. Check the developer tools for the connection URI."),
@@ -265,4 +265,4 @@ export function hasArgs(arg: string | string[] | undefined): boolean {
 		return true;
 	}
 	return false;
-}
+}
diff --git a/src/vs/platform/environment/node/environmentService.ts b/src/vs/platform/environment/node/environmentService.ts
@@ -222,7 +222,6 @@ export class EnvironmentService implements IEnvironmentService {
 
 	get logExtensionHostCommunication(): boolean { return !!this._args.logExtensionHostCommunication; }
 
-	get performance(): boolean { return !!this._args.performance; }
 	get status(): boolean { return !!this._args.status; }
 
 	@memoize
diff --git a/src/vs/workbench/parts/performance/electron-browser/perfviewEditor.ts b/src/vs/workbench/parts/performance/electron-browser/perfviewEditor.ts
@@ -104,7 +104,7 @@ class PerfModelContentProvider implements ITextModelContentProvider {
 		]).then(([metrics]) => {
 			if (!this._model.isDisposed()) {
 
-				let stats = this._envService.performance ? LoaderStats.get() : undefined;
+				let stats = this._envService.args['prof-modules'] ? LoaderStats.get() : undefined;
 				let md = new MarkdownBuilder();
 				this._addSummary(md, metrics);
 				md.blank();
