fix range vs postion regression in quick outline

jrieken · jrieken · commit f4ff74a51194 · 2019-08-26T16:38:12.000+02:00
diff --git a/src/vs/workbench/contrib/quickopen/browser/gotoSymbolHandler.ts b/src/vs/workbench/contrib/quickopen/browser/gotoSymbolHandler.ts
@@ -17,7 +17,7 @@ import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen';
 import { ITextEditorOptions } from 'vs/platform/editor/common/editor';
 import { getDocumentSymbols } from 'vs/editor/contrib/quickOpen/quickOpen';
 import { DocumentSymbolProviderRegistry, DocumentSymbol, symbolKindToCssClass, SymbolKind, SymbolTag } from 'vs/editor/common/modes';
-import { IRange } from 'vs/editor/common/core/range';
+import { IRange, Range } from 'vs/editor/common/core/range';
 import { themeColorFromId } from 'vs/platform/theme/common/themeService';
 import { overviewRulerRangeHighlight } from 'vs/editor/common/view/editorColorRegistry';
 import { GroupIdentifier, IEditorInput } from 'vs/workbench/common/editor';
@@ -219,7 +219,7 @@ class SymbolEntry extends EditorQuickOpenEntryGroup {
 
 	getOptions(pinned?: boolean): ITextEditorOptions {
 		return {
-			selection: this.revealRange,
+			selection: Range.collapseToStart(this.revealRange),
 			pinned
 		};
 	}
@@ -242,7 +242,7 @@ class SymbolEntry extends EditorQuickOpenEntryGroup {
 
 		// Apply selection and focus
 		else {
-			const range = this.revealRange;
+			const range = Range.collapseToStart(this.revealRange);
 			const activeTextEditorWidget = this.editorService.activeTextEditorWidget;
 			if (activeTextEditorWidget) {
 				activeTextEditorWidget.setSelection(range);
@@ -256,7 +256,7 @@ class SymbolEntry extends EditorQuickOpenEntryGroup {
 	private runPreview(): boolean {
 
 		// Select Outline Position
-		const range = this.revealRange;
+		const range = Range.collapseToStart(this.revealRange);
 		const activeTextEditorWidget = this.editorService.activeTextEditorWidget;
 		if (activeTextEditorWidget) {
 			activeTextEditorWidget.revealRangeInCenter(range, ScrollType.Smooth);
