💄 editor group perf

Benjamin Pasero · Benjamin Pasero · commit f357d44e31e5 · 2020-04-27T08:00:28.000+02:00
diff --git a/src/vs/workbench/common/editor/editorGroup.ts b/src/vs/workbench/common/editor/editorGroup.ts
@@ -383,7 +383,7 @@ export class EditorGroup extends Disposable {
 
 	moveEditor(candidate: EditorInput, toIndex: number): EditorInput | undefined {
 		const index = this.indexOf(candidate);
-		if (index < 0) {
+		if (index < 0 || toIndex === index) {
 			return;
 		}
 
@@ -481,6 +481,10 @@ export class EditorGroup extends Disposable {
 	isPinned(editor: EditorInput): boolean;
 	isPinned(index: number): boolean;
 	isPinned(arg1: EditorInput | number): boolean {
+		if (!this.preview) {
+			return true; // no preview editor
+		}
+
 		let editor: EditorInput;
 		let index: number;
 		if (typeof arg1 === 'number') {
