Fix error telemetry issue

Tyriar · Tyriar · commit f33cb5ceabf2 · 2020-07-15T05:30:33.000-07:00
Fixes microsoft#102558
diff --git a/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts b/src/vs/workbench/contrib/terminal/browser/links/terminalLinkHelpers.ts
@@ -94,13 +94,16 @@ export function convertBufferRangeToViewport(bufferRange: IBufferRange, viewport
 }
 
 export function getXtermLineContent(buffer: IBuffer, lineStart: number, lineEnd: number, cols: number): string {
-	let line = '';
+	let content = '';
 	for (let i = lineStart; i <= lineEnd; i++) {
 		// Make sure only 0 to cols are considered as resizing when windows mode is enabled will
 		// retain buffer data outside of the terminal width as reflow is disabled.
-		line += buffer.getLine(i)!.translateToString(true, 0, cols);
+		const line = buffer.getLine(i);
+		if (line) {
+			content += line.translateToString(true, 0, cols);
+		}
 	}
-	return line;
+	return content;
 }
 
 export function positionIsInRange(position: IBufferCellPosition, range: IBufferRange): boolean {

Original file line number	Diff line number	Diff line change
`@@ -94,13 +94,16 @@ export function convertBufferRangeToViewport(bufferRange: IBufferRange, viewport`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`export function getXtermLineContent(buffer: IBuffer, lineStart: number, lineEnd: number, cols: number): string {`
`97`		`- let line = '';`
	`97`	`+ let content = '';`
`98`	`98`	`for (let i = lineStart; i <= lineEnd; i++) {`
`99`	`99`	`// Make sure only 0 to cols are considered as resizing when windows mode is enabled will`
`100`	`100`	`// retain buffer data outside of the terminal width as reflow is disabled.`
`101`		`- line += buffer.getLine(i)!.translateToString(true, 0, cols);`
	`101`	`+ const line = buffer.getLine(i);`
	`102`	`+ if (line) {`
	`103`	`+ content += line.translateToString(true, 0, cols);`
	`104`	`+ }`
`102`	`105`	`}`
`103`		`- return line;`
	`106`	`+ return content;`
`104`	`107`	`}`
`105`	`108`
`106`	`109`	`export function positionIsInRange(position: IBufferCellPosition, range: IBufferRange): boolean {`