Skip to content

Commit f2c4707

Browse files
author
Benjamin Pasero
committed
tslint: less implicit any use
1 parent 7215ec2 commit f2c4707

51 files changed

Lines changed: 74 additions & 105 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/vs/base/browser/builder.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -692,7 +692,7 @@ export class Builder implements IDisposable {
692692
}
693693
};
694694

695-
return this.on(arg1, fn, listenerToUnbindContainer);
695+
return this.on(arg1, fn, listenerToUnbindContainer, useCapture);
696696
}
697697

698698
/**

‎src/vs/base/browser/event.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,14 +114,14 @@ export interface IDomEvent {
114114
(element: EventHandler, type: string, useCapture?: boolean): _Event<any>;
115115
}
116116

117-
export const domEvent: IDomEvent = (element: EventHandler, type: string, useCapture?) => {
117+
export const domEvent: IDomEvent = (element: EventHandler, type: string, useCapture?: boolean) => {
118118
const fn = e => emitter.fire(e);
119119
const emitter = new Emitter<any>({
120120
onFirstListenerAdd: () => {
121-
element.addEventListener(type, fn);
121+
element.addEventListener(type, fn, useCapture);
122122
},
123123
onLastListenerRemove: () => {
124-
element.removeEventListener(type, fn);
124+
element.removeEventListener(type, fn, useCapture);
125125
}
126126
});
127127

‎src/vs/base/browser/htmlContentRenderer.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ function _renderHtml(content: IHTMLContentElement, options: RenderOptions = {}):
9191

9292
const renderer = new marked.Renderer();
9393
renderer.image = (href: string, title: string, text: string) => {
94-
let dimensions = [];
94+
let dimensions: string[] = [];
9595
if (href) {
9696
const splitted = href.split('|').map(s => s.trim());
9797
href = splitted[0];

‎src/vs/base/browser/ui/list/listView.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ export class ListView<T> implements IDisposable {
240240
return DOM.addDisposableListener(domNode, type, handler, useCapture);
241241
}
242242

243-
private fireScopedEvent(handler: (event: any) => void, index) {
243+
private fireScopedEvent(handler: (event: any) => void, index: number) {
244244
if (index < 0) {
245245
return;
246246
}

‎src/vs/base/browser/ui/list/listWidget.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class Trait<T> implements IDisposable {
6565
splice(start: number, deleteCount: number, insertCount: number): void {
6666
const diff = insertCount - deleteCount;
6767
const end = start + deleteCount;
68-
const indexes = [];
68+
const indexes: number[] = [];
6969

7070
for (let index of indexes) {
7171
if (index >= start && index < end) {
@@ -110,7 +110,7 @@ class Trait<T> implements IDisposable {
110110

111111
class FocusTrait<T> extends Trait<T> {
112112

113-
constructor(private getElementId: (number) => string) {
113+
constructor(private getElementId: (number: number) => string) {
114114
super('focused');
115115
}
116116

‎src/vs/base/common/async.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ export function sequence<T>(promiseFactories: ITask<TPromise<T>>[]): TPromise<T[
402402
export function first<T>(promiseFactories: ITask<TPromise<T>>[], shouldStop: (t: T) => boolean = t => !!t): TPromise<T> {
403403
promiseFactories = [...promiseFactories.reverse()];
404404

405-
const loop = () => {
405+
const loop: () => TPromise<T> = () => {
406406
if (promiseFactories.length === 0) {
407407
return TPromise.as(null);
408408
}

‎src/vs/base/common/color.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ function hsla2rgba(hsla: HSLA): RGBA {
6565
let s = Math.min(hsla.s, 1);
6666
let l = Math.min(hsla.l, 1);
6767
let a = hsla.a === void 0 ? hsla.a : 1;
68-
let r, g, b;
68+
let r: number, g: number, b: number;
6969

7070
if (s === 0) {
7171
r = g = b = l; // achromatic
7272
} else {
73-
let hue2rgb = function hue2rgb(p, q, t) {
73+
let hue2rgb = function hue2rgb(p: number, q: number, t: number) {
7474
if (t < 0) {
7575
t += 1;
7676
}
@@ -115,7 +115,7 @@ export class Color {
115115
* Returns the number in the set [0, 1]. O => Darkest Black. 1 => Lightest white.
116116
*/
117117
public getLuminosity(): number {
118-
let luminosityFor = function (color): number {
118+
let luminosityFor = function (color: number): number {
119119
let c = color / 255;
120120
return (c <= 0.03928) ? c / 12.92 : Math.pow(((c + 0.055) / 1.055), 2.4);
121121
};

‎src/vs/base/common/comparers.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ export function compareByPrefix(one: string, other: string, lookFor: string): nu
8383
}
8484

8585
export interface IScorableResourceAccessor<T> {
86-
getLabel(T): string;
87-
getResourcePath(T): string;
86+
getLabel(t: T): string;
87+
getResourcePath(t: T): string;
8888
}
8989

9090
export function compareByScore<T>(elementA: T, elementB: T, accessor: IScorableResourceAccessor<T>, lookFor: string, lookForNormalizedLower: string, scorerCache?: { [key: string]: number }): number {

‎src/vs/base/common/decorators.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export function memoize(target: any, key: string, descriptor: any) {
2323

2424
const memoizeKey = `$memoize$${key}`;
2525

26-
descriptor[fnKey] = function (...args) {
26+
descriptor[fnKey] = function (...args: any[]) {
2727
if (!this.hasOwnProperty(memoizeKey)) {
2828
Object.defineProperty(this, memoizeKey, {
2929
configurable: false,

‎src/vs/base/common/diagnostics.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ globals.Monaco.Diagnostics = {};
1919

2020
var switches = globals.Monaco.Diagnostics;
2121
var map = {};
22-
var data = [];
22+
var data: any[] = [];
2323

2424
function fifo(array: any[], size: number) {
2525
while (array.length > size) {

0 commit comments

Comments
 (0)