Fix opening of tree items with keyboard (microsoft#78187)

alexr00 · web-flow · commit f2b65a9601b5 · 2019-07-30T17:21:15.000+02:00
Up until very recently, the custom tree used a TreeResourceNavigator2 with openOnSelection: true. This caused command to be executed twice on clicks though. Once on the selection and once on the click. Setting that to false caused the enter key to stop causing commands to run though. This was because the enter key was only causing the selection to trigger, not the open. The Open event was getting swallowed before it made it out of the tree because it was missing a UIEvent. Adding the UIEvent in here fixes that Fixes microsoft#78174
diff --git a/src/vs/base/browser/ui/tree/asyncDataTree.ts b/src/vs/base/browser/ui/tree/asyncDataTree.ts
@@ -602,9 +602,9 @@ export class AsyncDataTree<TInput, T, TFilterData = void> implements IDisposable
 		return nodes.map(n => n!.element as T);
 	}
 
-	open(elements: T[]): void {
+	open(elements: T[], browserEvent?: UIEvent): void {
 		const nodes = elements.map(e => this.getDataNode(e));
-		this.tree.open(nodes);
+		this.tree.open(nodes, browserEvent);
 	}
 
 	reveal(element: T, relativeTop?: number): void {

Original file line number	Diff line number	Diff line change
`@@ -602,9 +602,9 @@ export class AsyncDataTree<TInput, T, TFilterData = void> implements IDisposable`
`602`	`602`	`return nodes.map(n => n!.element as T);`
`603`	`603`	`}`
`604`	`604`
`605`		`- open(elements: T[]): void {`
	`605`	`+ open(elements: T[], browserEvent?: UIEvent): void {`
`606`	`606`	`const nodes = elements.map(e => this.getDataNode(e));`
`607`		`- this.tree.open(nodes);`
	`607`	`+ this.tree.open(nodes, browserEvent);`
`608`	`608`	`}`
`609`	`609`
`610`	`610`	`reveal(element: T, relativeTop?: number): void {`