Remove test editing code from preview

mjbvz · mjbvz · commit f085deb2e076 · 2019-11-22T15:18:01.000-08:00
diff --git a/extensions/image-preview/package.json b/extensions/image-preview/package.json
@@ -44,11 +44,6 @@
         "command": "imagePreview.zoomOut",
         "title": "%command.zoomOut%",
         "category": "Image Preview"
-      },
-      {
-        "command": "imagePreview.testing.makeEdit",
-        "title": "Make test edit",
-        "category": "Image Preview"
       }
     ],
     "menus": {
@@ -62,11 +57,6 @@
           "command": "imagePreview.zoomOut",
           "when": "imagePreviewFocus",
           "group": "1_imagePreview"
-        },
-        {
-          "command": "imagePreview.testing.makeEdit",
-          "when": "imagePreviewTestMode",
-          "group": "1_imagePreview"
         }
       ]
     }
diff --git a/extensions/image-preview/src/extension.ts b/extensions/image-preview/src/extension.ts
@@ -38,20 +38,5 @@ export function activate(context: vscode.ExtensionContext) {
 	context.subscriptions.push(vscode.commands.registerCommand('imagePreview.zoomOut', () => {
 		previewManager.activePreview?.zoomOut();
 	}));
-
-	context.subscriptions.push(vscode.commands.registerCommand('imagePreview.testing.makeEdit', () => {
-		previewManager.activePreview?.test_makeEdit();
-	}));
-
-	context.subscriptions.push(vscode.workspace.onDidChangeConfiguration(e => {
-		if (e.affectsConfiguration('imagePreview.customEditorTestMode')) {
-			updateTestMode();
-		}
-	}));
-	updateTestMode();
 }
 
-function updateTestMode() {
-	const isInTestMode = vscode.workspace.getConfiguration('imagePreview').get<boolean>('customEditorTestMode', false);
-	vscode.commands.executeCommand('setContext', 'imagePreviewTestMode', isInTestMode);
-}
diff --git a/extensions/image-preview/src/preview.ts b/extensions/image-preview/src/preview.ts
@@ -45,9 +45,7 @@ export class PreviewManager {
 			}
 		});
 
-		return {
-			editingCapability: preview
-		};
+		return {};
 	}
 
 	public get activePreview() { return this._activePreview; }
@@ -68,7 +66,7 @@ const enum PreviewState {
 	Active,
 }
 
-class Preview extends Disposable implements vscode.WebviewEditorEditingCapability {
+class Preview extends Disposable {
 
 	private readonly id: string = `${Date.now()}-${Math.random().toString()}`;
 
@@ -251,24 +249,6 @@ class Preview extends Disposable implements vscode.WebviewEditorEditingCapabilit
 			path: this.extensionRoot.path + path
 		}));
 	}
-
-	//#region WebviewEditorCapabilities
-	private readonly _onEdit = this._register(new vscode.EventEmitter<{ now: number }>());
-	public readonly onEdit = this._onEdit.event;
-
-	async save() { console.log('save'); }
-
-	async hotExit() { }
-
-	async undoEdits(edits: any[]) { console.log('undo', edits); }
-
-	async applyEdits(edits: any[]) { console.log('apply', edits); }
-
-	//#endregion
-
-	public test_makeEdit() {
-		this._onEdit.fire({ now: Date.now() });
-	}
 }
 
 function escapeAttribute(value: string | vscode.Uri): string {
diff --git a/src/vs/workbench/contrib/customEditor/common/customEditorModel.ts b/src/vs/workbench/contrib/customEditor/common/customEditorModel.ts
@@ -122,5 +122,3 @@ export class CustomEditorModel extends Disposable implements ICustomEditorModel
 		this.updateDirty();
 	}
 }
-
-

Original file line number	Diff line number	Diff line change
`@@ -44,11 +44,6 @@`
`44`	`44`	`"command": "imagePreview.zoomOut",`
`45`	`45`	`"title": "%command.zoomOut%",`
`46`	`46`	`"category": "Image Preview"`
`47`		`- },`
`48`		`- {`
`49`		`- "command": "imagePreview.testing.makeEdit",`
`50`		`- "title": "Make test edit",`
`51`		`- "category": "Image Preview"`
`52`	`47`	`}`
`53`	`48`	`],`
`54`	`49`	`"menus": {`
`@@ -62,11 +57,6 @@`
`62`	`57`	`"command": "imagePreview.zoomOut",`
`63`	`58`	`"when": "imagePreviewFocus",`
`64`	`59`	`"group": "1_imagePreview"`
`65`		`- },`
`66`		`- {`
`67`		`- "command": "imagePreview.testing.makeEdit",`
`68`		`- "when": "imagePreviewTestMode",`
`69`		`- "group": "1_imagePreview"`
`70`	`60`	`}`
`71`	`61`	`]`
`72`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -122,5 +122,3 @@ export class CustomEditorModel extends Disposable implements ICustomEditorModel`
`122`	`122`	`this.updateDirty();`
`123`	`123`	`}`
`124`	`124`	`}`
`125`		`-`
`126`		`-`