Fix microsoft#103238

sandy081 · sandy081 · commit f063ff93f4a4 · 2020-09-02T18:51:58.000+02:00
diff --git a/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts b/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts
@@ -431,6 +431,9 @@ export class UserDataSyncWorkbenchContribution extends Disposable implements IWo
 
 	private async turnOn(): Promise<void> {
 		try {
+			if (!this.userDataSyncWorkbenchService.authenticationProviders.length) {
+				throw new Error(localize('no authentication providers', "No authentication providers available."));
+			}
 			if (!this.storageService.getBoolean('sync.donotAskPreviewConfirmation', StorageScope.GLOBAL, false)) {
 				if (!await this.askForConfirmation()) {
 					return;
@@ -478,7 +481,7 @@ export class UserDataSyncWorkbenchContribution extends Disposable implements IWo
 						return;
 				}
 			}
-			this.notificationService.error(localize('turn on failed', "Error while starting Sync: {0}", toErrorMessage(e)));
+			this.notificationService.error(localize('turn on failed', "Error while starting Settings Sync: {0}", toErrorMessage(e)));
 		}
 	}
 
diff --git a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts
@@ -246,6 +246,9 @@ export class UserDataSyncWorkbenchService extends Disposable implements IUserDat
 	}
 
 	async turnOn(): Promise<void> {
+		if (!this.authenticationProviders.length) {
+			throw new Error(localize('no authentication providers', "Settings sync cannot be turned on because there are no authentication providers available."));
+		}
 		if (this.userDataAutoSyncService.isEnabled()) {
 			return;
 		}

Original file line number	Diff line number	Diff line change
`@@ -431,6 +431,9 @@ export class UserDataSyncWorkbenchContribution extends Disposable implements IWo`
`431`	`431`
`432`	`432`	`private async turnOn(): Promise<void> {`
`433`	`433`	`try {`
	`434`	`+ if (!this.userDataSyncWorkbenchService.authenticationProviders.length) {`
	`435`	`+ throw new Error(localize('no authentication providers', "No authentication providers available."));`
	`436`	`+ }`
`434`	`437`	`if (!this.storageService.getBoolean('sync.donotAskPreviewConfirmation', StorageScope.GLOBAL, false)) {`
`435`	`438`	`if (!await this.askForConfirmation()) {`
`436`	`439`	`return;`
`@@ -478,7 +481,7 @@ export class UserDataSyncWorkbenchContribution extends Disposable implements IWo`
`478`	`481`	`return;`
`479`	`482`	`}`
`480`	`483`	`}`
`481`		`- this.notificationService.error(localize('turn on failed', "Error while starting Sync: {0}", toErrorMessage(e)));`
	`484`	`+ this.notificationService.error(localize('turn on failed', "Error while starting Settings Sync: {0}", toErrorMessage(e)));`
`482`	`485`	`}`
`483`	`486`	`}`
`484`	`487`
Original file line number	Diff line number	Diff line change
`@@ -246,6 +246,9 @@ export class UserDataSyncWorkbenchService extends Disposable implements IUserDat`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`async turnOn(): Promise<void> {`
	`249`	`+ if (!this.authenticationProviders.length) {`
	`250`	`+ throw new Error(localize('no authentication providers', "Settings sync cannot be turned on because there are no authentication providers available."));`
	`251`	`+ }`
`249`	`252`	`if (this.userDataAutoSyncService.isEnabled()) {`
`250`	`253`	`return;`
`251`	`254`	`}`