Update

Tyriar · Tyriar · commit ef93f6eb65fe · 2020-06-18T05:53:38.000-07:00
diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts
@@ -670,8 +670,9 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ
 			return;
 		}
 		cachedLink.provider.handleTerminalLink(cachedLink.link);
-
-		// TODO: Handle when result is false
+		// TODO: Handle when result is false? Should this be return void instead and remove
+		// TerminalLink.target? It's a simple call to window.openUri for the extension otherwise
+		// and would simplify the API.
 	}
 
 	private _onProcessExit(id: number, exitCode: number | undefined): void {

Original file line number	Diff line number	Diff line change
`@@ -670,8 +670,9 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ`
`670`	`670`	`return;`
`671`	`671`	`}`
`672`	`672`	`cachedLink.provider.handleTerminalLink(cachedLink.link);`
`673`		`-`
`674`		`- // TODO: Handle when result is false`
	`673`	`+ // TODO: Handle when result is false? Should this be return void instead and remove`
	`674`	`+ // TerminalLink.target? It's a simple call to window.openUri for the extension otherwise`
	`675`	`+ // and would simplify the API.`
`675`	`676`	`}`
`676`	`677`
`677`	`678`	`private _onProcessExit(id: number, exitCode: number \| undefined): void {`