Set token if either the value or provider has changed (microsoft#96716)

Rachel Macfarlane · web-flow · commit ec9371ba4905 · 2020-04-30T10:19:18.000-07:00
diff --git a/src/vs/platform/authentication/common/authentication.ts b/src/vs/platform/authentication/common/authentication.ts
@@ -46,7 +46,7 @@ export class AuthenticationTokenService extends Disposable implements IAuthentic
 	}
 
 	async setToken(token: IUserDataSyncAuthToken | undefined): Promise<void> {
-		if (token && this._token ? token.token !== this._token.token && token.authenticationProviderId !== this._token.authenticationProviderId : token !== this._token) {
+		if (token && this._token ? token.token !== this._token.token || token.authenticationProviderId !== this._token.authenticationProviderId : token !== this._token) {
 			this._token = token;
 			this._onDidChangeToken.fire(token);
 		}

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ export class AuthenticationTokenService extends Disposable implements IAuthentic`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`async setToken(token: IUserDataSyncAuthToken \| undefined): Promise<void> {`
`49`		`- if (token && this._token ? token.token !== this._token.token && token.authenticationProviderId !== this._token.authenticationProviderId : token !== this._token) {`
	`49`	`+ if (token && this._token ? token.token !== this._token.token \|\| token.authenticationProviderId !== this._token.authenticationProviderId : token !== this._token) {`
`50`	`50`	`this._token = token;`
`51`	`51`	`this._onDidChangeToken.fire(token);`
`52`	`52`	`}`