git: better uri parsing error message

joaomoreno · joaomoreno · commit ec8de4eb4519 · 2019-11-20T10:53:20.000+01:00
diff --git a/extensions/git/src/uri.ts b/extensions/git/src/uri.ts
@@ -17,7 +17,21 @@ export function isGitUri(uri: Uri): boolean {
 }
 
 export function fromGitUri(uri: Uri): GitUriParams {
-	return qs.parse(uri.query) as any;
+	const result = qs.parse(uri.query) as any;
+
+	if (!result) {
+		throw new Error('Invalid git URI: empty query');
+	}
+
+	if (typeof result.path !== 'string') {
+		throw new Error('Invalid git URI: missing path');
+	}
+
+	if (typeof result.ref !== 'string') {
+		throw new Error('Invalid git URI: missing ref');
+	}
+
+	return result;
 }
 
 export interface GitUriOptions {
