storage - narrow types for store() method

Benjamin Pasero · Benjamin Pasero · commit ebf240126deb · 2019-01-15T17:46:12.000+01:00
diff --git a/src/vs/base/node/storage.ts b/src/vs/base/node/storage.ts
@@ -64,7 +64,7 @@ export interface IStorage extends IDisposable {
 	getInteger(key: string, fallbackValue: number): number;
 	getInteger(key: string, fallbackValue?: number): number | undefined;
 
-	set(key: string, value: any): Promise<void>;
+	set(key: string, value: string | boolean | number): Promise<void>;
 	delete(key: string): Promise<void>;
 
 	close(): Promise<void>;
@@ -207,7 +207,7 @@ export class Storage extends Disposable implements IStorage {
 		return parseInt(value, 10);
 	}
 
-	set(key: string, value: any): Promise<void> {
+	set(key: string, value: string | boolean | number): Promise<void> {
 		if (this.state === StorageState.Closed) {
 			return Promise.resolve(); // Return early if we are already closed
 		}
diff --git a/src/vs/platform/storage/common/storage.ts b/src/vs/platform/storage/common/storage.ts
@@ -71,13 +71,12 @@ export interface IStorageService {
 	getInteger<R extends number | undefined>(key: string, scope: StorageScope, fallbackValue?: number): number | undefined;
 
 	/**
-	 * Store a string value under the given key to storage. The value will
-	 * be converted to a string.
+	 * Store a value under the given key to storage. The value will be converted to a string.
 	 *
 	 * The scope argument allows to define the scope of the storage
 	 * operation to either the current workspace only or all workspaces.
 	 */
-	store(key: string, value: any, scope: StorageScope): void;
+	store(key: string, value: string | boolean | number, scope: StorageScope): void;
 
 	/**
 	 * Delete an element stored under the provided key from storage.
@@ -154,7 +153,7 @@ export class InMemoryStorageService extends Disposable implements IStorageServic
 		return parseInt(value, 10);
 	}
 
-	store(key: string, value: any, scope: StorageScope): Promise<void> {
+	store(key: string, value: string | boolean | number, scope: StorageScope): Promise<void> {
 
 		// We remove the key for undefined/null values
 		if (isUndefinedOrNull(value)) {
diff --git a/src/vs/platform/storage/node/storageService.ts b/src/vs/platform/storage/node/storageService.ts
@@ -205,7 +205,7 @@ export class StorageService extends Disposable implements IStorageService {
 		return this.getStorage(scope).getInteger(key, fallbackValue);
 	}
 
-	store(key: string, value: any, scope: StorageScope): void {
+	store(key: string, value: string | boolean | number, scope: StorageScope): void {
 		this.getStorage(scope).set(key, value);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ export interface IStorage extends IDisposable {`
`64`	`64`	`getInteger(key: string, fallbackValue: number): number;`
`65`	`65`	`getInteger(key: string, fallbackValue?: number): number \| undefined;`
`66`	`66`
`67`		`- set(key: string, value: any): Promise<void>;`
	`67`	`+ set(key: string, value: string \| boolean \| number): Promise<void>;`
`68`	`68`	`delete(key: string): Promise<void>;`
`69`	`69`
`70`	`70`	`close(): Promise<void>;`
`@@ -207,7 +207,7 @@ export class Storage extends Disposable implements IStorage {`
`207`	`207`	`return parseInt(value, 10);`
`208`	`208`	`}`
`209`	`209`
`210`		`- set(key: string, value: any): Promise<void> {`
	`210`	`+ set(key: string, value: string \| boolean \| number): Promise<void> {`
`211`	`211`	`if (this.state === StorageState.Closed) {`
`212`	`212`	`return Promise.resolve(); // Return early if we are already closed`
`213`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ export class StorageService extends Disposable implements IStorageService {`
`205`	`205`	`return this.getStorage(scope).getInteger(key, fallbackValue);`
`206`	`206`	`}`
`207`	`207`
`208`		`- store(key: string, value: any, scope: StorageScope): void {`
	`208`	`+ store(key: string, value: string \| boolean \| number, scope: StorageScope): void {`
`209`	`209`	`this.getStorage(scope).set(key, value);`
`210`	`210`	`}`
`211`	`211`