Move back button to QuickInputButtons (microsoft#53327)

chrmarti · chrmarti · commit ebf213ab68ee · 2018-07-23T11:20:17.000+02:00
diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts
@@ -701,14 +701,6 @@ declare module 'vscode' {
 
 	export namespace window {
 
-		/**
-		 * A back button for [QuickPick](#QuickPick) and [InputBox](#InputBox).
-		 *
-		 * When a navigation 'back' button is needed this one should be used for consistency.
-		 * It comes with a predefined icon, tooltip and location.
-		 */
-		export const quickInputBackButton: QuickInputButton;
-
 		/**
 		 * Creates a [QuickPick](#QuickPick) to let the user pick an item from a list
 		 * of items of type T.
@@ -977,6 +969,20 @@ declare module 'vscode' {
 		readonly tooltip?: string | undefined;
 	}
 
+	/**
+	 * Predefined buttons for [QuickPick](#QuickPick) and [InputBox](#InputBox).
+	 */
+	export namespace QuickInputButtons {
+
+		/**
+		 * A back button for [QuickPick](#QuickPick) and [InputBox](#InputBox).
+		 *
+		 * When a navigation 'back' button is needed this one should be used for consistency.
+		 * It comes with a predefined icon, tooltip and location.
+		 */
+		export const Back: QuickInputButton;
+	}
+
 	//#endregion
 
 	//#region joh: https://github.com/Microsoft/vscode/issues/10659
diff --git a/src/vs/workbench/api/node/extHost.api.impl.ts b/src/vs/workbench/api/node/extHost.api.impl.ts
@@ -455,11 +455,6 @@ export function createApiFactory(
 			registerUriHandler(handler: vscode.UriHandler) {
 				return extHostUrls.registerUriHandler(extension.id, handler);
 			},
-			get quickInputBackButton() {
-				return proposedApiFunction(extension, (): vscode.QuickInputButton => {
-					return extHostQuickOpen.backButton;
-				})();
-			},
 			createQuickPick: proposedApiFunction(extension, <T extends vscode.QuickPickItem>(): vscode.QuickPick<T> => {
 				return extHostQuickOpen.createQuickPick(extension.id);
 			}),
@@ -468,6 +463,15 @@ export function createApiFactory(
 			}),
 		};
 
+		// namespace: QuickInputButtons
+		const QuickInputButtons: typeof vscode.QuickInputButtons = {
+			get Back() {
+				return proposedApiFunction(extension, (): vscode.QuickInputButton => {
+					return extHostQuickOpen.backButton;
+				})();
+			},
+		};
+
 		// namespace: workspace
 		const workspace: typeof vscode.workspace = {
 			get rootPath() {
@@ -722,6 +726,7 @@ export function createApiFactory(
 			OverviewRulerLane: OverviewRulerLane,
 			ParameterInformation: extHostTypes.ParameterInformation,
 			Position: extHostTypes.Position,
+			QuickInputButtons,
 			Range: extHostTypes.Range,
 			Selection: extHostTypes.Selection,
 			SignatureHelp: extHostTypes.SignatureHelp,
