Fixes useExec promise not returning if there's no work to do

MOZGIII · web-flow · commit eb17fc81bb96 · 2019-03-03T07:38:40.000+03:00
diff --git a/src/vs/base/node/processes.ts b/src/vs/base/node/processes.ts
@@ -321,14 +321,14 @@ export abstract class AbstractProcess<TProgressData> {
 	private useExec(): Promise<boolean> {
 		return new Promise<boolean>((c, e) => {
 			if (!this.shell || !Platform.isWindows) {
-				c(false);
+				return c(false);
 			}
 			let cmdShell = cp.spawn(getWindowsShell(), ['/s', '/c']);
 			cmdShell.on('error', (error: Error) => {
-				c(true);
+				return c(true);
 			});
 			cmdShell.on('exit', (data: any) => {
-				c(false);
+				return c(false);
 			});
 		});
 	}
@@ -470,4 +470,4 @@ export namespace win32 {
 		}
 		return path.join(cwd, command);
 	}
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -321,14 +321,14 @@ export abstract class AbstractProcess<TProgressData> {`
`321`	`321`	`private useExec(): Promise<boolean> {`
`322`	`322`	`return new Promise<boolean>((c, e) => {`
`323`	`323`	`if (!this.shell \|\| !Platform.isWindows) {`
`324`		`- c(false);`
	`324`	`+ return c(false);`
`325`	`325`	`}`
`326`	`326`	`let cmdShell = cp.spawn(getWindowsShell(), ['/s', '/c']);`
`327`	`327`	`cmdShell.on('error', (error: Error) => {`
`328`		`- c(true);`
	`328`	`+ return c(true);`
`329`	`329`	`});`
`330`	`330`	`cmdShell.on('exit', (data: any) => {`
`331`		`- c(false);`
	`331`	`+ return c(false);`
`332`	`332`	`});`
`333`	`333`	`});`
`334`	`334`	`}`
`@@ -470,4 +470,4 @@ export namespace win32 {`
`470`	`470`	`}`
`471`	`471`	`return path.join(cwd, command);`
`472`	`472`	`}`
`473`		`-}`
	`473`	`+}`