Revert "fixes microsoft#78167"

sbatten · sbatten · commit e8c6bfcec702 · 2019-08-09T15:52:19.000-07:00
Breaks custom titlebar and menu This reverts commit a417a06.
diff --git a/src/vs/base/browser/ui/grid/gridview.ts b/src/vs/base/browser/ui/grid/gridview.ts
@@ -348,7 +348,6 @@ class BranchNode implements ISplitView, IDisposable {
 		}
 
 		this.splitview.setViewVisible(index, visible);
-		this._onDidChange.fire(undefined);
 	}
 
 	getChildCachedVisibleSize(index: number): number | undefined {
diff --git a/src/vs/base/browser/ui/splitview/splitview.css b/src/vs/base/browser/ui/splitview/splitview.css
@@ -39,7 +39,6 @@
 	white-space: initial;
 	flex: none;
 	position: relative;
-	overflow: hidden;
 }
 
 .monaco-split-view2 > .split-view-container > .split-view-view:not(.visible) {
@@ -73,4 +72,4 @@
 .monaco-split-view2.separator-border.vertical > .split-view-container > .split-view-view:not(:first-child)::before {
 	height: 1px;
 	width: 100%;
-}
+}
diff --git a/src/vs/base/browser/ui/splitview/splitview.ts b/src/vs/base/browser/ui/splitview/splitview.ts
@@ -125,10 +125,7 @@ abstract class ViewItem {
 		dom.addClass(container, 'visible');
 	}
 
-	layout(): void {
-		this.container.scrollTop = 0;
-		this.container.scrollLeft = 0;
-	}
+	abstract layout(): void;
 
 	layoutView(orientation: Orientation): void {
 		this.view.layout(this.size, orientation);
@@ -143,7 +140,6 @@ abstract class ViewItem {
 class VerticalViewItem extends ViewItem {
 
 	layout(): void {
-		super.layout();
 		this.container.style.height = `${this.size}px`;
 		this.layoutView(Orientation.VERTICAL);
 	}
@@ -152,7 +148,6 @@ class VerticalViewItem extends ViewItem {
 class HorizontalViewItem extends ViewItem {
 
 	layout(): void {
-		super.layout();
 		this.container.style.width = `${this.size}px`;
 		this.layoutView(Orientation.HORIZONTAL);
 	}

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,6 @@ class BranchNode implements ISplitView, IDisposable {`
`348`	`348`	`}`
`349`	`349`
`350`	`350`	`this.splitview.setViewVisible(index, visible);`
`351`		`- this._onDidChange.fire(undefined);`
`352`	`351`	`}`
`353`	`352`
`354`	`353`	`getChildCachedVisibleSize(index: number): number \| undefined {`