dispose command-palette after usage, microsoft#62829

jrieken · jrieken · commit e839e4560c19 · 2018-11-09T13:16:16.000+01:00
diff --git a/src/vs/workbench/parts/quickopen/browser/commandsHandler.ts b/src/vs/workbench/parts/quickopen/browser/commandsHandler.ts
@@ -425,6 +425,7 @@ export class CommandsHandler extends QuickOpenHandler {
 			const menu = this.editorService.invokeWithinEditorContext(accessor => this.menuService.createMenu(MenuId.CommandPalette, accessor.get(IContextKeyService)));
 			const menuActions = menu.getActions().reduce((r, [, actions]) => [...r, ...actions], <MenuItemAction[]>[]).filter(action => action instanceof MenuItemAction) as MenuItemAction[];
 			const commandEntries = this.menuItemActionsToEntries(menuActions, searchValue);
+			menu.dispose();
 
 			// Concat
 			let entries = [...editorEntries, ...commandEntries];
