web - no errors when deleting files that do not exist (inMemory)

Benjamin Pasero · Benjamin Pasero · commit e7aa84d8abef · 2019-12-06T15:55:40.000+01:00
diff --git a/src/vs/workbench/services/userData/common/inMemoryUserDataProvider.ts b/src/vs/workbench/services/userData/common/inMemoryUserDataProvider.ts
@@ -131,16 +131,19 @@ export class InMemoryFileSystemProvider extends Disposable implements IFileSyste
 	}
 
 	async delete(resource: URI, opts: FileDeleteOptions): Promise<void> {
-		let dirname = resources.dirname(resource);
-		let basename = resources.basename(resource);
-		let parent = this._lookupAsDirectory(dirname, false);
-		if (!parent.entries.has(basename)) {
-			throw new FileSystemProviderError('file not found', FileSystemProviderErrorCode.FileNotFound);
+		try {
+			let dirname = resources.dirname(resource);
+			let basename = resources.basename(resource);
+			let parent = this._lookupAsDirectory(dirname, false);
+			if (parent.entries.has(basename)) {
+				parent.entries.delete(basename);
+				parent.mtime = Date.now();
+				parent.size -= 1;
+				this._fireSoon({ type: FileChangeType.UPDATED, resource: dirname }, { resource, type: FileChangeType.DELETED });
+			}
+		} catch (error) {
+			// ignore if resource does not exist to keep parity with other file system providers
 		}
-		parent.entries.delete(basename);
-		parent.mtime = Date.now();
-		parent.size -= 1;
-		this._fireSoon({ type: FileChangeType.UPDATED, resource: dirname }, { resource, type: FileChangeType.DELETED });
 	}
 
 	async mkdir(resource: URI): Promise<void> {
