Strict null check appInsightsAppender

mjbvz · mjbvz · commit e6b5fd3e9e7e · 2018-12-10T17:14:01.000-08:00
diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json
@@ -511,6 +511,7 @@
 		"./vs/platform/telemetry/common/telemetry.ts",
 		"./vs/platform/telemetry/common/telemetryService.ts",
 		"./vs/platform/telemetry/common/telemetryUtils.ts",
+		"./vs/platform/telemetry/node/appInsightsAppender.ts",
 		"./vs/platform/telemetry/node/commonProperties.ts",
 		"./vs/platform/telemetry/node/telemetryIpc.ts",
 		"./vs/platform/telemetry/node/telemetryNodeUtils.ts",
@@ -592,6 +593,7 @@
 		"./vs/workbench/parts/codeEditor/electron-browser/toggleWordWrap.ts",
 		"./vs/workbench/parts/comments/common/commentModel.ts",
 		"./vs/workbench/parts/comments/electron-browser/commentGlyphWidget.ts",
+		"./vs/workbench/parts/debug/node/telemetryApp.ts",
 		"./vs/workbench/parts/emmet/browser/actions/showEmmetCommands.ts",
 		"./vs/workbench/parts/emmet/browser/emmet.browser.contribution.ts",
 		"./vs/workbench/parts/emmet/electron-browser/actions/expandAbbreviation.ts",
diff --git a/src/vs/platform/telemetry/common/telemetryUtils.ts b/src/vs/platform/telemetry/common/telemetryUtils.ts
@@ -29,7 +29,7 @@ export const NullTelemetryService = new class implements ITelemetryService {
 
 export interface ITelemetryAppender {
 	log(eventName: string, data: any): void;
-	dispose(): Thenable<any>;
+	dispose(): Thenable<any> | undefined;
 }
 
 export function combinedAppender(...appenders: ITelemetryAppender[]): ITelemetryAppender {
diff --git a/src/vs/platform/telemetry/node/appInsightsAppender.ts b/src/vs/platform/telemetry/node/appInsightsAppender.ts
@@ -45,7 +45,7 @@ interface Measurements {
 
 export class AppInsightsAppender implements ITelemetryAppender {
 
-	private _aiClient: appInsights.TelemetryClient;
+	private _aiClient?: appInsights.TelemetryClient;
 
 	constructor(
 		private _eventPrefix: string,
@@ -143,10 +143,10 @@ export class AppInsightsAppender implements ITelemetryAppender {
 		});
 	}
 
-	dispose(): Promise<any> {
+	dispose(): Promise<any> | undefined {
 		if (this._aiClient) {
 			return new Promise(resolve => {
-				this._aiClient.flush({
+				this._aiClient!.flush({
 					callback: () => {
 						// all data flushed
 						this._aiClient = undefined;

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export const NullTelemetryService = new class implements ITelemetryService {`
`29`	`29`
`30`	`30`	`export interface ITelemetryAppender {`
`31`	`31`	`log(eventName: string, data: any): void;`
`32`		`- dispose(): Thenable<any>;`
	`32`	`+ dispose(): Thenable<any> \| undefined;`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`export function combinedAppender(...appenders: ITelemetryAppender[]): ITelemetryAppender {`