remove activation message from command service... microsoft#59645

jrieken · jrieken · commit e684d1b3fb4e · 2018-10-23T15:54:45.000+02:00
diff --git a/src/vs/workbench/services/commands/common/commandService.ts b/src/vs/workbench/services/commands/common/commandService.ts
@@ -9,8 +9,6 @@ import { IExtensionService } from 'vs/workbench/services/extensions/common/exten
 import { Event, Emitter } from 'vs/base/common/event';
 import { Disposable } from 'vs/base/common/lifecycle';
 import { ILogService } from 'vs/platform/log/common/log';
-import { IProgressService2, ProgressLocation } from 'vs/platform/progress/common/progress';
-import { localize } from 'vs/nls';
 
 export class CommandService extends Disposable implements ICommandService {
 
@@ -24,8 +22,7 @@ export class CommandService extends Disposable implements ICommandService {
 	constructor(
 		@IInstantiationService private readonly _instantiationService: IInstantiationService,
 		@IExtensionService private readonly _extensionService: IExtensionService,
-		@ILogService private readonly _logService: ILogService,
-		@IProgressService2 private readonly _progressService: IProgressService2,
+		@ILogService private readonly _logService: ILogService
 	) {
 		super();
 		this._extensionService.whenInstalledExtensionsRegistered().then(value => this._extensionHostIsReady = value);
@@ -48,12 +45,6 @@ export class CommandService extends Disposable implements ICommandService {
 			if (!commandIsRegistered) {
 				waitFor = Promise.all([activation, this._extensionService.activateByEvent(`*`)]);
 			}
-
-			this._progressService.withProgress({
-				location: ProgressLocation.Window,
-				title: localize('activating', "Activating extensions for command '{0}'...", id)
-			}, () => waitFor);
-
 			return (waitFor as Promise<any>).then(_ => this._tryExecuteCommand(id, args));
 		}
 	}
diff --git a/src/vs/workbench/services/commands/test/common/commandService.test.ts b/src/vs/workbench/services/commands/test/common/commandService.test.ts
@@ -11,7 +11,6 @@ import { InstantiationService } from 'vs/platform/instantiation/common/instantia
 import { IExtensionPoint } from 'vs/workbench/services/extensions/common/extensionsRegistry';
 import { Event, Emitter } from 'vs/base/common/event';
 import { NullLogService } from 'vs/platform/log/common/log';
-import { IProgressService2 } from 'vs/platform/progress/common/progress';
 
 class SimpleExtensionService implements IExtensionService {
 	_serviceBrand: any;
@@ -54,17 +53,6 @@ class SimpleExtensionService implements IExtensionService {
 
 suite('CommandService', function () {
 
-	interface Ctor<T> {
-		new(): T;
-	}
-	function mock<T>(): Ctor<T> {
-		return function () { } as any;
-	}
-
-	let progressService = new class extends mock<IProgressService2>() {
-		withProgress() { return null; }
-	};
-
 	let commandRegistration: IDisposable;
 
 	setup(function () {
@@ -84,7 +72,7 @@ suite('CommandService', function () {
 				lastEvent = activationEvent;
 				return super.activateByEvent(activationEvent);
 			}
-		}, new NullLogService(), progressService);
+		}, new NullLogService());
 
 		return service.executeCommand('foo').then(() => {
 			assert.ok(lastEvent, 'onCommand:foo');
@@ -104,7 +92,7 @@ suite('CommandService', function () {
 			}
 		};
 
-		let service = new CommandService(new InstantiationService(), extensionService, new NullLogService(), progressService);
+		let service = new CommandService(new InstantiationService(), extensionService, new NullLogService());
 
 		await extensionService.whenInstalledExtensionsRegistered();
 
@@ -122,7 +110,7 @@ suite('CommandService', function () {
 			whenInstalledExtensionsRegistered() {
 				return new Promise<boolean>(_resolve => { /*ignore*/ });
 			}
-		}, new NullLogService(), progressService);
+		}, new NullLogService());
 
 		service.executeCommand('bar');
 		assert.equal(callCounter, 1);
@@ -139,7 +127,7 @@ suite('CommandService', function () {
 			whenInstalledExtensionsRegistered() {
 				return whenInstalledExtensionsRegistered;
 			}
-		}, new NullLogService(), progressService);
+		}, new NullLogService());
 
 		let r = service.executeCommand('bar');
 		assert.equal(callCounter, 0);
