make sure all, not some, decorations are unused before removing its css rule, microsoft#81467

jrieken · jrieken · commit e520a1bcef8e · 2019-10-01T18:14:20.000+02:00
diff --git a/src/vs/workbench/services/decorations/browser/decorationsService.ts b/src/vs/workbench/services/decorations/browser/decorationsService.ts
@@ -172,7 +172,7 @@ class DecorationStyles extends Disposable {
 			if (value.isUnused()) {
 				let remove: boolean = false;
 				if (Array.isArray(data)) {
-					remove = data.some(data => !usedDecorations.has(DecorationRule.keyOf(data)));
+					remove = data.every(data => !usedDecorations.has(DecorationRule.keyOf(data)));
 				} else if (!usedDecorations.has(DecorationRule.keyOf(data))) {
 					remove = true;
 				}

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ class DecorationStyles extends Disposable {`
`172`	`172`	`if (value.isUnused()) {`
`173`	`173`	`let remove: boolean = false;`
`174`	`174`	`if (Array.isArray(data)) {`
`175`		`- remove = data.some(data => !usedDecorations.has(DecorationRule.keyOf(data)));`
	`175`	`+ remove = data.every(data => !usedDecorations.has(DecorationRule.keyOf(data)));`
`176`	`176`	`} else if (!usedDecorations.has(DecorationRule.keyOf(data))) {`
`177`	`177`	`remove = true;`
`178`	`178`	`}`