Skip to content

Commit e51bb9b

Browse files
committed
fix unit test.
1 parent 6c68514 commit e51bb9b

1 file changed

Lines changed: 14 additions & 17 deletions

File tree

src/vs/workbench/api/common/extHostNotebook.ts

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -938,31 +938,28 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
938938
this._notebookContentProviders.set(viewType, { extension, provider });
939939

940940
const listener = provider.onDidChangeNotebook
941-
? provider.onDidChangeNotebook(e => this._proxy.$onNotebookChange(viewType, e.document.uri))
941+
? provider.onDidChangeNotebook(e => {
942+
const document = this._documents.get(URI.revive(e.document.uri).toString());
943+
944+
if (!document) {
945+
throw new Error(`Notebook document ${e.document.uri.toString()} not found`);
946+
}
947+
948+
if (isEditEvent(e)) {
949+
const editId = document.addEdit(e);
950+
this._proxy.$onDidEdit(e.document.uri, viewType, editId, e.label);
951+
} else {
952+
this._proxy.$onContentChange(e.document.uri, viewType);
953+
}
954+
})
942955
: Disposable.None;
943956

944957
const supportBackup = !!provider.backupNotebook;
945958

946959
this._proxy.$registerNotebookProvider({ id: extension.identifier, location: extension.extensionLocation }, viewType, supportBackup, provider.kernel ? { id: viewType, label: provider.kernel.label, extensionLocation: extension.extensionLocation, preloads: provider.kernel.preloads } : undefined);
947960

948-
const contentChangeListener = provider.onDidChangeNotebook(e => {
949-
const document = this._documents.get(URI.revive(e.document.uri).toString());
950-
951-
if (!document) {
952-
throw new Error(`Notebook document ${e.document.uri.toString()} not found`);
953-
}
954-
955-
if (isEditEvent(e)) {
956-
const editId = document.addEdit(e);
957-
this._proxy.$onDidEdit(e.document.uri, viewType, editId, e.label);
958-
} else {
959-
this._proxy.$onContentChange(e.document.uri, viewType);
960-
}
961-
});
962-
963961
return new extHostTypes.Disposable(() => {
964962
listener.dispose();
965-
contentChangeListener.dispose();
966963
this._notebookContentProviders.delete(viewType);
967964
this._proxy.$unregisterNotebookProvider(viewType);
968965
});

0 commit comments

Comments
 (0)