Fixes microsoft#48831: fetchTasks does not return customized tasks.

dbaeumer · dbaeumer · commit e3860b3357db · 2018-04-27T16:26:03.000+02:00
diff --git a/src/vs/workbench/parts/tasks/common/tasks.ts b/src/vs/workbench/parts/tasks/common/tasks.ts
@@ -456,6 +456,12 @@ export namespace CustomTask {
 		};
 		return result;
 	}
+	export function customizes(task: CustomTask): TaskIdentifier {
+		if (task._source && task._source.customizes) {
+			return task._source.customizes;
+		}
+		return undefined;
+	}
 }
 
 export interface ConfiguringTask extends CommonTask, ConfigurationProperties {
diff --git a/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts b/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts
@@ -696,9 +696,17 @@ class TaskService implements ITaskService {
 			let result: Task[] = [];
 			map.forEach((tasks) => {
 				for (let task of tasks) {
-					let definition = Task.getTaskDefinition(task);
-					if (definition && definition.type === filter.type) {
+					if (ContributedTask.is(task) && task.defines.type === filter.type) {
 						result.push(task);
+					} else if (CustomTask.is(task)) {
+						if (task.type === filter.type) {
+							result.push(task);
+						} else {
+							let customizes = CustomTask.customizes(task);
+							if (customizes && customizes.type === filter.type) {
+								result.push(task);
+							}
+						}
 					}
 				}
 			});

Original file line number	Diff line number	Diff line change
`@@ -456,6 +456,12 @@ export namespace CustomTask {`
`456`	`456`	`};`
`457`	`457`	`return result;`
`458`	`458`	`}`
	`459`	`+ export function customizes(task: CustomTask): TaskIdentifier {`
	`460`	`+ if (task._source && task._source.customizes) {`
	`461`	`+ return task._source.customizes;`
	`462`	`+ }`
	`463`	`+ return undefined;`
	`464`	`+ }`
`459`	`465`	`}`
`460`	`466`
`461`	`467`	`export interface ConfiguringTask extends CommonTask, ConfigurationProperties {`