Skip to content

Commit df2143f

Browse files
committed
remove todos
1 parent 89ac4c9 commit df2143f

3 files changed

Lines changed: 0 additions & 5 deletions

File tree

extensions/git/src/commands.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,6 @@ export class CommandCenter {
744744
const message = await getCommitMessage();
745745

746746
if (!message) {
747-
// TODO@joao: show modal dialog to confirm empty message commit
748747
return false;
749748
}
750749

@@ -1287,7 +1286,6 @@ export class CommandCenter {
12871286
return result;
12881287
}
12891288

1290-
// TODO@Joao: possibly remove? do we really need to return resources?
12911289
private getSCMResource(uri?: Uri): Resource | undefined {
12921290
uri = uri ? uri : window.activeTextEditor && window.activeTextEditor.document.uri;
12931291

@@ -1322,7 +1320,6 @@ export class CommandCenter {
13221320
const groups = resources.reduce((result, resource) => {
13231321
const repository = this.model.getRepository(resource);
13241322

1325-
// TODO@Joao: what should happen?
13261323
if (!repository) {
13271324
console.warn('Could not find git repository for ', resource);
13281325
return result;

extensions/git/src/repository.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,6 @@ export class Repository implements Disposable {
411411
this.status();
412412
}
413413

414-
// TODO@Joao reorganize this
415414
provideOriginalResource(uri: Uri): Uri | undefined {
416415
if (uri.scheme !== 'file') {
417416
return;

extensions/git/src/util.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ export function once(fn: (...args: any[]) => any): (...args: any[]) => any {
8383
};
8484
}
8585

86-
// TODO@Joao: replace with Object.assign
8786
export function assign<T>(destination: T, ...sources: any[]): T {
8887
for (const source of sources) {
8988
Object.keys(source).forEach(key => destination[key] = source[key]);

0 commit comments

Comments
 (0)