💄

rebornix · rebornix · commit de5ddeca616d · 2020-05-20T11:07:27.000-07:00
diff --git a/extensions/vscode-notebook-tests/src/notebook.test.ts b/extensions/vscode-notebook-tests/src/notebook.test.ts
@@ -118,7 +118,7 @@ suite('API tests', () => {
 			]
 		});
 
-		const moveCellEvent = getEventOncePromise<vscode.NotebookCellMoveEvent>(vscode.notebook.onDidChangeNotebookCells);
+		const moveCellEvent = getEventOncePromise<vscode.NotebookCellsChangeEvent>(vscode.notebook.onDidChangeNotebookCells);
 		await vscode.commands.executeCommand('notebook.cell.moveUp');
 		const moveCellEventRet = await moveCellEvent;
 		assert.deepEqual(moveCellEventRet, {
diff --git a/extensions/vscode-notebook-tests/src/notebookSmokeTestMain.ts b/extensions/vscode-notebook-tests/src/notebookSmokeTestMain.ts
@@ -50,6 +50,26 @@ export function smokeTestActivate(context: vscode.ExtensionContext): any {
 
 			return dto;
 		},
+		saveNotebook: async (_document: vscode.NotebookDocument, _cancellation: vscode.CancellationToken) => {
+			return;
+		},
+		saveNotebookAs: async (_targetResource: vscode.Uri, _document: vscode.NotebookDocument, _cancellation: vscode.CancellationToken) => {
+			return;
+		}
+	}));
+
+	context.subscriptions.push(vscode.notebook.registerNotebookKernel('notebookSmokeTest', ['*.vsctestnb'], {
+		label: 'notebookSmokeTest',
+		executeAllCells: async (_document: vscode.NotebookDocument) => {
+			for (let i = 0; i < _document.cells.length; i++) {
+				_document.cells[i].outputs = [{
+					outputKind: vscode.CellOutputKind.Rich,
+					data: {
+						'text/html': ['test output']
+					}
+				}];
+			}
+		},
 		executeCell: async (_document: vscode.NotebookDocument, _cell: vscode.NotebookCell | undefined, _token: vscode.CancellationToken) => {
 			if (!_cell) {
 				_cell = _document.cells[0];
@@ -63,11 +83,5 @@ export function smokeTestActivate(context: vscode.ExtensionContext): any {
 			}];
 			return;
 		},
-		saveNotebook: async (_document: vscode.NotebookDocument, _cancellation: vscode.CancellationToken) => {
-			return;
-		},
-		saveNotebookAs: async (_targetResource: vscode.Uri, _document: vscode.NotebookDocument, _cancellation: vscode.CancellationToken) => {
-			return;
-		}
 	}));
 }
diff --git a/src/vs/workbench/api/common/extHostNotebookConcatDocument.ts b/src/vs/workbench/api/common/extHostNotebookConcatDocument.ts
@@ -52,7 +52,6 @@ export class ExtHostNotebookConcatDocument implements vscode.NotebookConcatTextD
 			}
 		};
 
-		this._disposables.add(extHostNotebooks.onDidMoveNotebookCell(e => documentChange(e.document)));
 		this._disposables.add(extHostNotebooks.onDidChangeCellLanguage(e => documentChange(e.document)));
 		this._disposables.add(extHostNotebooks.onDidChangeCellOutputs(e => documentChange(e.document)));
 		this._disposables.add(extHostNotebooks.onDidChangeNotebookCells(e => documentChange(e.document)));
diff --git a/src/vs/workbench/contrib/notebook/browser/viewModel/markdownCellViewModel.ts b/src/vs/workbench/contrib/notebook/browser/viewModel/markdownCellViewModel.ts
@@ -9,7 +9,7 @@ import * as editorCommon from 'vs/editor/common/editorCommon';
 import * as model from 'vs/editor/common/model';
 import { ITextModelService } from 'vs/editor/common/services/resolverService';
 import { BOTTOM_CELL_TOOLBAR_HEIGHT, CELL_MARGIN, CELL_RUN_GUTTER } from 'vs/workbench/contrib/notebook/browser/constants';
-import { CellEditState, CellFindMatch, ICellViewModel, MarkdownCellLayoutChangeEvent, MarkdownCellLayoutInfo, NotebookLayoutInfo } from 'vs/workbench/contrib/notebook/browser/notebookBrowser';
+import { CellFindMatch, ICellViewModel, MarkdownCellLayoutChangeEvent, MarkdownCellLayoutInfo, NotebookLayoutInfo } from 'vs/workbench/contrib/notebook/browser/notebookBrowser';
 import { MarkdownRenderer } from 'vs/workbench/contrib/notebook/browser/view/renderers/mdRenderer';
 import { BaseCellViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/baseCellViewModel';
 import { EditorFoldingStateDelegate } from 'vs/workbench/contrib/notebook/browser/contrib/fold/foldingModel';

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ suite('API tests', () => {`
`118`	`118`	`]`
`119`	`119`	`});`
`120`	`120`
`121`		`- const moveCellEvent = getEventOncePromise<vscode.NotebookCellMoveEvent>(vscode.notebook.onDidChangeNotebookCells);`
	`121`	`+ const moveCellEvent = getEventOncePromise<vscode.NotebookCellsChangeEvent>(vscode.notebook.onDidChangeNotebookCells);`
`122`	`122`	`await vscode.commands.executeCommand('notebook.cell.moveUp');`
`123`	`123`	`const moveCellEventRet = await moveCellEvent;`
`124`	`124`	`assert.deepEqual(moveCellEventRet, {`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,6 @@ export class ExtHostNotebookConcatDocument implements vscode.NotebookConcatTextD`
`52`	`52`	`}`
`53`	`53`	`};`
`54`	`54`
`55`		`- this._disposables.add(extHostNotebooks.onDidMoveNotebookCell(e => documentChange(e.document)));`
`56`	`55`	`this._disposables.add(extHostNotebooks.onDidChangeCellLanguage(e => documentChange(e.document)));`
`57`	`56`	`this._disposables.add(extHostNotebooks.onDidChangeCellOutputs(e => documentChange(e.document)));`
`58`	`57`	`this._disposables.add(extHostNotebooks.onDidChangeNotebookCells(e => documentChange(e.document)));`