Skip to content

Commit ddfccd4

Browse files
committed
fix keybindings remote content
1 parent 183e40f commit ddfccd4

2 files changed

Lines changed: 18 additions & 4 deletions

File tree

src/vs/platform/userDataSync/common/keybindingsSync.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,15 @@ export class KeybindingsSynchroniser extends AbstractSynchroniser implements IUs
240240
}
241241

242242
async getRemoteContent(): Promise<string | null> {
243-
const remoteUserData = await this.getRemoteUserData();
244-
return remoteUserData.content;
243+
let content: string | null | undefined = null;
244+
if (this.syncPreviewResultPromise) {
245+
const preview = await this.syncPreviewResultPromise;
246+
content = preview.remoteUserData?.content;
247+
} else {
248+
const remoteUserData = await this.getRemoteUserData();
249+
content = remoteUserData.content;
250+
}
251+
return content ? this.getKeybindingsContentFromSyncContent(content) : null;
245252
}
246253

247254
async resetLocal(): Promise<void> {

src/vs/platform/userDataSync/common/settingsSync.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,15 @@ export class SettingsSynchroniser extends AbstractSynchroniser implements ISetti
240240
}
241241

242242
async getRemoteContent(): Promise<string | null> {
243-
const remoteUserData = await this.getRemoteUserData();
244-
return remoteUserData.content;
243+
let content: string | null | undefined = null;
244+
if (this.syncPreviewResultPromise) {
245+
const preview = await this.syncPreviewResultPromise;
246+
content = preview.remoteUserData?.content;
247+
} else {
248+
const remoteUserData = await this.getRemoteUserData();
249+
content = remoteUserData.content;
250+
}
251+
return content !== undefined ? content : null;
245252
}
246253

247254
async resolveConflicts(resolvedConflicts: { key: string, value: any | undefined }[]): Promise<void> {

0 commit comments

Comments
 (0)