Extend dispoable

mjbvz · mjbvz · commit dbfca928e018 · 2019-08-23T22:27:51.000-05:00
diff --git a/src/vs/editor/contrib/parameterHints/parameterHints.ts b/src/vs/editor/contrib/parameterHints/parameterHints.ts
@@ -5,7 +5,7 @@
 
 import * as nls from 'vs/nls';
 import { KeyCode, KeyMod } from 'vs/base/common/keyCodes';
-import { dispose } from 'vs/base/common/lifecycle';
+import { Disposable } from 'vs/base/common/lifecycle';
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
 import { IEditorContribution } from 'vs/editor/common/editorCommon';
 import { EditorContextKeys } from 'vs/editor/common/editorContextKeys';
@@ -18,7 +18,7 @@ import { KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegis
 import * as modes from 'vs/editor/common/modes';
 import { TriggerContext } from 'vs/editor/contrib/parameterHints/parameterHintsModel';
 
-class ParameterHintsController implements IEditorContribution {
+class ParameterHintsController extends Disposable implements IEditorContribution {
 
 	private static readonly ID = 'editor.controller.parameterHints';
 
@@ -30,8 +30,9 @@ class ParameterHintsController implements IEditorContribution {
 	private readonly widget: ParameterHintsWidget;
 
 	constructor(editor: ICodeEditor, @IInstantiationService instantiationService: IInstantiationService) {
+		super();
 		this.editor = editor;
-		this.widget = instantiationService.createInstance(ParameterHintsWidget, this.editor);
+		this.widget = this._register(instantiationService.createInstance(ParameterHintsWidget, this.editor));
 	}
 
 	getId(): string {
@@ -53,10 +54,6 @@ class ParameterHintsController implements IEditorContribution {
 	trigger(context: TriggerContext): void {
 		this.widget.trigger(context);
 	}
-
-	dispose(): void {
-		dispose(this.widget);
-	}
 }
 
 export class TriggerParameterHintsAction extends EditorAction {
@@ -76,7 +73,7 @@ export class TriggerParameterHintsAction extends EditorAction {
 	}
 
 	public run(accessor: ServicesAccessor, editor: ICodeEditor): void {
-		let controller = ParameterHintsController.get(editor);
+		const controller = ParameterHintsController.get(editor);
 		if (controller) {
 			controller.trigger({
 				triggerKind: modes.SignatureHelpTriggerKind.Invoke
